Skip to content

Conversation

@MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Feb 14, 2022

What's changed and what's your intention?

As titled. FYI: #298

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#298

@MrCroxx MrCroxx changed the title chore(ci): temp disable unstable source check query fix: ignore the failed case in source e2e test Feb 14, 2022
@MrCroxx MrCroxx enabled auto-merge (squash) February 14, 2022 13:07
@MrCroxx MrCroxx requested a review from shanicky February 14, 2022 13:08
@github-actions github-actions bot added type/fix Type: Bug fix. Only for pull requests. and removed type/chore labels Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #313 (d131986) into main (2721cd3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #313      +/-   ##
============================================
- Coverage     74.21%   74.20%   -0.01%     
  Complexity     2665     2665              
============================================
  Files           856      856              
  Lines         48496    48496              
  Branches       1586     1586              
============================================
- Hits          35989    35988       -1     
- Misses        11695    11696       +1     
  Partials        812      812              
Flag Coverage Δ
java 61.93% <ø> (ø)
rust 79.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2721cd3...d131986. Read the comment docs.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCroxx MrCroxx merged commit b37caff into main Feb 14, 2022
@MrCroxx MrCroxx deleted the xx/disable-source-check branch February 14, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants