fix: ignore the failed case in source e2e test #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
============================================
- Coverage 74.33% 74.33% -0.01%
Complexity 2665 2665
============================================
Files 854 854
Lines 48189 48189
Branches 1586 1586
============================================
- Hits 35822 35821 -1
- Misses 11555 11556 +1
Partials 812 812
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ab270d3 to
a632317
Compare
skyzh
approved these changes
Feb 14, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This is expected because Kafka guarantees at-least-once delivery by default. It would be fixed after our low-level Kafka source merged.
Checklist
Refer to a related PR or issue link (optional)
closes #290