Skip to content

fix(storage): mview scan will miss keys #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2022
Merged

fix(storage): mview scan will miss keys #184

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
829f73c
fix(storage): mview scan will miss keys
skyzh Feb 10, 2022
d21ae3b
Merge branch 'main' into skyzh/fix-missing-key
skyzh Feb 10, 2022
af6a1b7
fix clippy errors
skyzh Feb 10, 2022
03baf1e
fix
skyzh Feb 10, 2022
c11d6a5
Merge branch 'main' of https://github.com/singularity-data/risingwave…
skyzh Feb 10, 2022
a8423d8
fix
skyzh Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions rust/storage/src/table/mview.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ use risingwave_common::util::ordered::*;
use risingwave_common::util::sort_util::OrderType;

use super::TableIterRef;
use crate::hummock::key::next_key;
use crate::table::{ScannableTable, TableIter};
use crate::{Keyspace, StateStore, TableColumnDesc};

Expand Down Expand Up @@ -182,17 +181,21 @@ impl<'a, S: StateStore> MViewTableIter<S> {
async fn consume_more(&mut self) -> Result<()> {
// TODO: adjustable limit
assert!(self.next_idx == self.buf.len());
let limit: usize = 100;
let limit: usize = 1024;
if self.buf.is_empty() {
self.buf = self.keyspace.scan(Some(limit), self.epoch).await?
self.buf = self.keyspace.scan(Some(limit), self.epoch).await?;
} else {
let next_key = next_key(self.buf.last().unwrap().0.to_vec().as_slice());
self.buf = self
let last_key = self.buf.last().unwrap().0.clone();
let buf = self
.keyspace
.scan_with_start_key(next_key, Some(limit), self.epoch)
.await?
.scan_with_start_key(last_key.to_vec(), Some(limit), self.epoch)
.await?;
assert!(!buf.is_empty());
assert_eq!(buf.first().as_ref().unwrap().0, last_key);
// TODO: remove the unnecessary clone here
self.buf = buf[1..].to_vec();
}
self.next_idx = 0;

Ok(())
}
}
Expand Down