fix(storage): mview scan will miss keys #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
hzxa21
reviewed
Feb 10, 2022
rust/storage/src/table/mview.rs
Outdated
| .scan_with_start_key(last_key.to_vec(), Some(limit), self.epoch) | ||
| .await?; | ||
| assert!(!self.buf.is_empty()); | ||
| assert_eq!(self.buf.first().as_ref().unwrap().0, last_key); |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert_eq!(self.buf.first().as_ref().unwrap().0, last_key); | |
| assert_eq!(buf.first().as_ref().unwrap().0, last_key); |
…-dev into skyzh/fix-missing-key
Signed-off-by: Alex Chi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
============================================
- Coverage 74.49% 74.49% -0.01%
Complexity 2654 2654
============================================
Files 837 837
Lines 47761 47763 +2
Branches 1562 1562
============================================
+ Hits 35581 35582 +1
- Misses 11381 11382 +1
Partials 799 799
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi [email protected]
What's changed and what's your intention?
In the original implementation, if we have:
a, ab, bc
and it occurs that the last key we get is
a. next_key(a) =b. We will missab.This PR fixes the bug.
Checklist
Refer to a related PR or issue link (optional)
#62