Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 14, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

introduced in #874

@skyzh skyzh requested a review from fuyufjh March 14, 2022 07:43
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Mar 14, 2022
@skyzh skyzh enabled auto-merge (squash) March 14, 2022 07:45
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #891 (aba4a6d) into main (7be7027) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #891   +/-   ##
=========================================
  Coverage     72.31%   72.32%           
  Complexity     2766     2766           
=========================================
  Files           935      935           
  Lines         54992    54992           
  Branches       1787     1787           
=========================================
+ Hits          39770    39773    +3     
+ Misses        14332    14329    -3     
  Partials        890      890           
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/cluster/mod.rs 75.26% <0.00%> (+0.35%) ⬆️
rust/meta/src/model/cluster.rs 86.66% <0.00%> (+13.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 9afeec4 into main Mar 14, 2022
@skyzh skyzh deleted the skyzh/build-risedev-in-building branch March 14, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants