Skip to content

feat(storage): support read epoch for in-memory state backend #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

feat(storage): support read epoch for in-memory state backend #874

merged 1 commit into from
Mar 14, 2022

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 14, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Support read epoch for in-memory state backend. At the same time, enable full lookup executor test.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #852

@skyzh skyzh requested review from BugenZhao and TennyZhuang March 14, 2022 03:07
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 14, 2022
BugenZhao
BugenZhao approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems no need to implement wait_epoch as well currently.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #874 (566d2b4) into main (67ae66b) will increase coverage by 0.08%.
The diff coverage is 82.08%.

@@             Coverage Diff              @@
##               main     #874      +/-   ##
============================================
+ Coverage     72.20%   72.28%   +0.08%     
  Complexity     2766     2766              
============================================
  Files           931      931              
  Lines         54671    54740      +69     
  Branches       1787     1787              
============================================
+ Hits          39473    39567      +94     
+ Misses        14308    14283      -25     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.75% <82.08%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/storage/src/store_impl.rs 4.54% <0.00%> (-0.22%) ⬇️
rust/stream/src/executor/lookup/tests.rs 100.00% <ø> (ø)
rust/storage/src/memory.rs 80.00% <85.93%> (+23.07%) ⬆️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
rust/meta/src/cluster/mod.rs 75.26% <0.00%> (+0.35%) ⬆️
rust/meta/src/hummock/compaction.rs 82.24% <0.00%> (+0.59%) ⬆️
rust/stream/src/executor/lookup/impl_.rs 79.38% <0.00%> (+1.03%) ⬆️
rust/meta/src/model/cluster.rs 86.66% <0.00%> (+13.33%) ⬆️
rust/stream/src/executor/lookup/sides.rs 71.05% <0.00%> (+31.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 7a8ed2d into main Mar 14, 2022
@skyzh skyzh deleted the skyzh/in-memory-epoch branch March 14, 2022 03:26
@skyzh skyzh mentioned this pull request Mar 14, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage: support read epoch for in-memory state backend

3 participants

@skyzh @BugenZhao