Skip to content

fix(streaming): hang up source when failed & panic on actor error #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2022
Merged

fix(streaming): hang up source when failed & panic on actor error #777

merged 5 commits into from
Mar 11, 2022

Conversation

@BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Mar 9, 2022 •
edited
Loading

What's changed and what's your intention?

This PR hangs up the source when it fails, and panic the actor if an error occurs.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Mar 9, 2022
@BugenZhao BugenZhao changed the title fix(streaming): hang up source when failed fix(streaming): hang up source when failed & panic on actor error Mar 11, 2022
@BugenZhao BugenZhao marked this pull request as ready for review March 11, 2022 05:32
@BugenZhao BugenZhao requested review from fuyufjh and skyzh March 11, 2022 05:32
MrCroxx
MrCroxx approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #777 (a5735f2) into main (9f2387b) will decrease coverage by 0.00%.
The diff coverage is 73.33%.

❗ Current head a5735f2 differs from pull request most recent head 7e135fb. Consider uploading reports for the commit 7e135fb to get more accurate results

@@             Coverage Diff              @@
##               main     #777      +/-   ##
============================================
- Coverage     72.02%   72.01%   -0.01%     
  Complexity     2766     2766              
============================================
  Files           927      927              
  Lines         54086    54092       +6     
  Branches       1787     1787              
============================================
+ Hits          38953    38954       +1     
- Misses        14243    14248       +5     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.45% <73.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor/source.rs 72.24% <57.14%> (-0.90%) ⬇️
rust/stream/src/task/stream_manager.rs 55.55% <87.50%> (+0.41%) ⬆️
rust/meta/src/hummock/compaction.rs 81.65% <0.00%> (-0.60%) ⬇️
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

skyzh
skyzh approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, good work!

@BugenZhao
use pending
7e135fb 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge (squash) March 11, 2022 07:49
@BugenZhao BugenZhao merged commit 53c479c into main Mar 11, 2022
@BugenZhao BugenZhao deleted the bz/hanging-source-when-failed branch March 11, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrCroxx MrCroxx MrCroxx approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

+1 more reviewer

@skyzh skyzh skyzh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BugenZhao @skyzh @MrCroxx