Skip to content

feat: report failed actors in barrier manager #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2022
Merged

feat: report failed actors in barrier manager #759

merged 4 commits into from
Mar 9, 2022

Conversation

@BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Mar 8, 2022

What's changed and what's your intention?

As mentioned in #736, if an actor failed, we should not further send and collect barriers from it. However, we should record this info in global barrier manager.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Close #742.

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 8, 2022
@BugenZhao
Copy link
Member Author

BugenZhao commented Mar 8, 2022 •
edited
Loading

Could you please help to test whether this PR works? @twocode @wcy-fdu

@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #759 (f11294a) into main (6bbc0be) will increase coverage by 0.01%.
The diff coverage is 56.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #759      +/-   ##
============================================
+ Coverage     72.43%   72.44%   +0.01%     
  Complexity     2759     2759              
============================================
  Files           911      911              
  Lines         52958    52958              
  Branches       1783     1783              
============================================
+ Hits          38358    38366       +8     
+ Misses        13708    13700       -8     
  Partials        892      892
Flag Coverage Δ
java 61.17% <ø> (ø)
rust 77.21% <56.81%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
rust/meta/src/stream/stream_manager.rs 72.68% <0.00%> (-0.33%) ⬇️
rust/stream/src/task/stream_manager.rs 53.84% <0.00%> (+0.68%) ⬆️
rust/stream/src/task/barrier_manager.rs 80.58% <66.66%> (+4.65%) ⬆️
rust/meta/src/barrier/mod.rs 59.28% <68.42%> (+2.14%) ⬆️
rust/meta/src/hummock/compaction.rs 81.43% <0.00%> (-0.60%) ⬇️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbc0be...f11294a. Read the comment docs.

@BugenZhao BugenZhao enabled auto-merge (squash) March 9, 2022 04:01
@BugenZhao BugenZhao merged commit f584ba8 into main Mar 9, 2022
@BugenZhao BugenZhao deleted the bz/global-barrier-manager-failed-actor branch March 9, 2022 04:04
fuyufjh pushed a commit that referenced this pull request Mar 9, 2022
Revert "feat: report failed actors in barrier manager (#759)"
79f464f 
This reverts commit f584ba8.
fuyufjh added a commit that referenced this pull request Mar 9, 2022
@fuyufjh
revert: actor cancellation (#795)
0f3e929 
* Revert "feat: report failed actors in barrier manager (#759)"

This reverts commit f584ba8.

* Revert "fix(#691): Source actor cancellation cause CN, MN to panic. (#736)"

This reverts commit 376c484.
@BugenZhao BugenZhao mentioned this pull request Mar 11, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@twocode twocode Awaiting requested review from twocode

@skyzh skyzh Awaiting requested review from skyzh

@yezizp2012 yezizp2012 Awaiting requested review from yezizp2012

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Global StreamManager handle unexpected actor errors.

3 participants

@BugenZhao @fuyufjh