Fix numpy #213
Merged
Fix numpy #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintw
reviewed
Nov 5, 2018
| np.genfromtxt(file_name, delimiter=",", | ||
| missing_values="", filling_values=-1) | ||
|
|
||
| def load(self): |
There was a problem hiding this comment.
Could you add a very brief docstring here? (Like the other functions in this module)
|
Looks great - thank you. I've just added one simple comment on a docstring I'd like you to add. I see Travis has passed, I'll just wait for AppVeyor to pass too, and then merge this. (Once this is merged, just pull from master in to your other PR and that should work too) |
|
Right added that doc string. Just waiting for travis and appveyor. |
|
This is passing for all except 3.5 on AppVeyor, and that seems to be because it timed out due to some weird conda download slowdowns. Merging anyway, as it's only a small change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the np.load function as an input, this will need to be merged prior to #207 as it depends on it being fixed.