Skip to content

Conversation

oew1v07
Copy link

@oew1v07 oew1v07 commented Oct 19, 2018

This solves #205 but needs to go through testing and can't be done locally.

@oew1v07
Copy link
Author

oew1v07 commented Oct 19, 2018

Just to say I've actually only done tests to create the sample data as for keras this takes a lot of functions. I'm wondering whether the simple model I created should be elsewhere - but I don't know where else would be reasonable.

@robintw
Copy link
Contributor

robintw commented Oct 19, 2018

The tests won't pass at the moment because you're working from an outdated version of the recipy repository (the PR to make the tests pass was only merged recently, since you started working on this PR).

In your branch on your local machine, run git pull upstream master, and then git push origin BRANCHNAME - ask me if you need more details. (If you don't have a remote called upstream then see https://help.github.com/articles/configuring-a-remote-for-a-fork/)

@robintw
Copy link
Contributor

robintw commented Oct 19, 2018

From what we did tonight looking at this (for those who don't know, @oew1v07 is my wife!), it seems that sorting out the merge conflicts got screwed up. You basically need to remove all the lines between source activate test-environment and your if statements - but double-check.

Added tests to check loading of models and weights
…han using data generator.

Everything now working. Need to ass these to the test_packages still.
Also added glob to the conda install list in travis
….yml

Loading and saving weights as well as loading data are tested so far.
More succinct writing of the conditional statement in the .travis.yml so
it only has python version = 2.7 or 3.5 or 3.6.
Also wrote imagedatagenerator into patchAI
This has to be done by creating a temp variable which is set is any of
python 2.7, 3.5 or 3.6 are installed or not if otherwise.

Also put the conda installs for tensorflow and keras on one line
@robintw
Copy link
Contributor

robintw commented Oct 29, 2018

Don't need to install glob - it's a python built in!

@robintw
Copy link
Contributor

robintw commented Nov 5, 2018

That's strange if the inputs aren't needed in the test_packages.yml file - as I'd have thought that the numpy patch would have picked up the input from the npz file. I should look into this.

@oew1v07
Copy link
Author

oew1v07 commented Nov 5, 2018

It's passing!!!!

@oew1v07 oew1v07 mentioned this pull request Nov 5, 2018
@oew1v07
Copy link
Author

oew1v07 commented Nov 6, 2018

Seem to have sorted the if statement using quotes. However now all my tests are failing as they are trying to be run when they don't work on certain versions on a windows machine (python 2.7 + tensorflow on *nix but not windows) Not sure how to fix this as the skip is in the yml file rather than the appveyor.

@oew1v07
Copy link
Author

oew1v07 commented Nov 6, 2018

Maybe I'll just have to skip 2.7 entirely

@oew1v07
Copy link
Author

oew1v07 commented Nov 6, 2018

Also just realised that now my if statement isn't working for the case where it's true.

@oew1v07
Copy link
Author

oew1v07 commented Nov 14, 2018

Ok so the conclusion from logging into appveyor is that the only way to fix all these problems is with separate lists for each python version.

Iris failed - ImportError: No module named 'netcdftime'
Pandas hdf stuff failed -
ImportError: DLL load failed: The specified module could not be found. for tables
and also
ImportError: HDFStore requires PyTables, "DLL load failed: The specified module could not be found."

Ironically all the keras tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants