-
Notifications
You must be signed in to change notification settings - Fork 42
Patched the library keras and created the tests for it. #205 #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added the file to the __init__.py
Added template script for testing keras
and mnist samples in class folders. Added joblib to the travis yml
train model. Also added utils for creating compile and fit dictionaries
Also changed model_dicts to self.model_dicts
Just to say I've actually only done tests to create the sample data as for keras this takes a lot of functions. I'm wondering whether the simple model I created should be elsewhere - but I don't know where else would be reasonable. |
The tests won't pass at the moment because you're working from an outdated version of the recipy repository (the PR to make the tests pass was only merged recently, since you started working on this PR). In your branch on your local machine, run |
From what we did tonight looking at this (for those who don't know, @oew1v07 is my wife!), it seems that sorting out the merge conflicts got screwed up. You basically need to remove all the lines between |
Created sample model.
Added tests to check loading of models and weights
…han using data generator. Everything now working. Need to ass these to the test_packages still.
Also added glob to the conda install list in travis
….yml Loading and saving weights as well as loading data are tested so far. More succinct writing of the conditional statement in the .travis.yml so it only has python version = 2.7 or 3.5 or 3.6. Also wrote imagedatagenerator into patchAI
This has to be done by creating a temp variable which is set is any of python 2.7, 3.5 or 3.6 are installed or not if otherwise. Also put the conda installs for tensorflow and keras on one line
Don't need to install glob - it's a python built in! |
added new numpy .npz file to load data into models
should stay in the folder. Deleted files to make sure everything is being created properly.
That's strange if the inputs aren't needed in the test_packages.yml file - as I'd have thought that the numpy patch would have picked up the input from the npz file. I should look into this. |
It's passing!!!! |
Seem to have sorted the if statement using quotes. However now all my tests are failing as they are trying to be run when they don't work on certain versions on a windows machine (python 2.7 + tensorflow on *nix but not windows) Not sure how to fix this as the skip is in the yml file rather than the appveyor. |
Maybe I'll just have to skip 2.7 entirely |
Also just realised that now my if statement isn't working for the case where it's true. |
Ok so the conclusion from logging into appveyor is that the only way to fix all these problems is with separate lists for each python version. Iris failed - Ironically all the keras tests pass. |
This solves #205 but needs to go through testing and can't be done locally.