Install matter-idl package in the editable mode in pigweed env #38410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38410: Size comparison from e0cda38 to 152b0f5 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Apr 15, 2025
andy31415
approved these changes
Apr 16, 2025
enkiusz
approved these changes
Apr 17, 2025
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Apr 21, 2025
…rements.build.txt (#13239) - After PR project-chip/connectedhomeip#38410 - we need to have environment variable `PW_PROJECT_ROOT` pointing to CHIP_ROOT
dsavitsky-dsr
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Apr 22, 2025
…ct-chip#38410) * Fix scripts/configure * Define PW_PROJECT_ROOT when installing requirements.build.txt * Keep generator storage classes in separate file * Define InMemoryStorage in matter.idl.generators.storage * Install matter-idl in editable mode in development env * Use "absolute" path in requirements.build.txt * Remove IDL import hacks
srividya-p
pushed a commit
to srividya-p/oss-fuzz
that referenced
this pull request
Apr 27, 2025
…rements.build.txt (google#13239) - After PR project-chip/connectedhomeip#38410 - we need to have environment variable `PW_PROJECT_ROOT` pointing to CHIP_ROOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of changes from #38196
Changes
InMemoryStorageused in scripts)Warning
The names and location of the
matter.idlscripts were changed. Now all command line tools are installed (in the editable mode) in the pigween env during bootstrap.As a consequence of that, when this PR is merged to master, it will be required to run
. scripts/bootstrap.shin order to install matter-idl package. Otherwise, build will fail withModuleNotFoundError: No module named 'matter'error (somewhere in build logs).Testing
CI will verify potential build breaks.
Manually verified that it is possible to have many packages with
matternamespace installed in editable or non-editable mode and imports work correctly for all these packages.