Various cleanups in the matter.idl module #38196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38196: Size comparison from bd2b4f5 to 6b9b384 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38196: Size comparison from bd2b4f5 to e4bad1b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Apr 2, 2025
andy31415
reviewed
Apr 2, 2025
|
PR #38196: Size comparison from 86e1daf to c89b15b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
enkiusz
requested changes
Apr 4, 2025
enkiusz
approved these changes
Apr 4, 2025
|
PR #38196: Size comparison from c0a7934 to b594ac9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38196: Size comparison from c0a7934 to c9d04c9 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #38196: Size comparison from c0a7934 to bc5c284 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Apr 17, 2025
andy31415
approved these changes
Apr 17, 2025
|
PR #38196: Size comparison from 9c5af69 to df7a1c4 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Apr 17, 2025
dsavitsky-dsr
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Apr 22, 2025
* Cleanup typos in the code * Simplify IDL usage in scripts * Fix matter_idl_generator_files * Keep tests only in matter-idl GN * Restyled by isort * Fix Java CI * Activate env prior to gn gen in gn_silabs_example.sh --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During transition tomatternamespace it will be necessary to install all modules in a single location, otherwise Python will not be able to import modules properly.Changes:- Use relative imports inmatter.idlmodule- Install matter-idl package in the editable mode in pigweed env- Reorganizematter.idl.generatorsmodule to break circular dependencyNow, this PR contains various cleanups originally done here, but not included in #38410
Testing
CI will verify