Fix Github CI for v1.4-branch
#40589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
adcaa78 to
e77e6d7
Compare
|
PR #40589: Size comparison from 9c70fab to e77e6d7 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #40589: Size comparison from 9c70fab to c93f27a Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
c93f27a to
f956e49
Compare
|
PR #40589: Size comparison from 9c70fab to f956e49 Full report (20 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #40589: Size comparison from 9c70fab to be7eb73 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ce62d95 to
4f7a3c3
Compare
|
PR #40589: Size comparison from 2acb65b to 4f7a3c3 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
4f7a3c3 to
16d4dc0
Compare
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
* Add debug log for endpoint full error * Also add assertions that no in use items * Clean up includes * Fix typo in message
This change is picked from the PR [project-chip#38845](project-chip#38845)
4bbdc89 to
539c714
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request aims to fix the Github CI for the v1.4-branch. The main changes involve adding a GitHub action to set up an IPv6 environment for CI runners and making tests in src/inet/tests/TestInetEndPoint.cpp more robust. The changes to the tests are good improvements, making them more resilient to environment variations and easier to debug. However, the new GitHub action script is missing sudo for commands that require root privileges, which will likely cause CI failures. My review includes a suggestion to fix this.
This reverts commit 025cc0c.
This doesn't work because of permission issues.
andy31415
approved these changes
Sep 2, 2025
|
Still waiting for zap check to run ... we seem to be very backlogged |
|
Is it normal that the zap job is still queued and not started after almost 24 hours? |
Co-authored-by: Andrei Litvin <[email protected]>
Updating this from our offline conversation: it seems we were referencing old ubuntu-20.04 runner images in that workflow and those are not available anymore and rather than failing, they hang forever. This is now fixed in this PR. Will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
v1.4-branchbranch pass Github CI.The problems were occurring because CI runners didn't have a proper IPv6 environment setup.
This PR sets the environment (this was done partially manually cherry-picking #38845), and there are small fixes cherry-picked (#38015, #38790) for the file
src/inet/TestInetEndPoint.cpp.Also cherry-picked the PR #37870, because github actions doesn't support runners with ubuntu-20.04.
Related issues
Issue #40499
Testing
The CI jobs need to pass.