Full enable IPV6 tests again in REPL #38845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meip into ipv4_in_repl_tests
tcarmelveilleux
approved these changes
May 9, 2025
|
PR #38845: Size comparison from 1f6aada to 5aaec44 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 9, 2025
Co-authored-by: Boris Zbarsky <[email protected]>
|
Admin-merge to not wait another 4 hours for CI. CI passed before typo fix. |
|
PR #38845: Size comparison from 1f6aada to 1cb2c40 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
zaid-google
pushed a commit
to zaid-google/connectedhomeip
that referenced
this pull request
May 12, 2025
* Allow ipv4 in repl tests * Update a quotation mark * Re-enable repl tests, add ipv6only again but disable network namespaces usage * Disabled some tests, added ability to keep going to get a report of ALL failing tests * Restyle * Undo changes to disable netns * Add back restyle conditional * Fix typo * Fix typo * Disabled a bunch of tests that showed up as failing in GH CI... will then try again! * Fix ipython tests * Try to enable ipv6 back * Don't need ipv4, only v6 in theory * Make IPV6 enabling as a reusable action * use ipv6 for linux tests too, just in case * Fix up jupyter tests. This was a PAIN! * Update shell * Update .github/workflows/tests.yaml Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Hayk10002
added a commit
to Hayk10002/connectedhomeip
that referenced
this pull request
Aug 28, 2025
This change is picked from the PR [project-chip#38845](project-chip#38845)
Hayk10002
added a commit
to Hayk10002/connectedhomeip
that referenced
this pull request
Aug 29, 2025
This change is picked from the PR [project-chip#38845](project-chip#38845)
andy31415
added a commit
that referenced
this pull request
Sep 3, 2025
* Fix TestInetEndPoint to pass even when computer is offline (#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up. * Add debug logs for test inet limits (#38790) * Add debug log for endpoint full error * Also add assertions that no in use items * Clean up includes * Fix typo in message * Setup ipv6 environment in `REPL Tests - Linux` CI job This change is picked from the PR [#38845](#38845) * Setup ipv6 environment in other places where it's needed * Add sudo to IPV6 setup commands for proper permissions * Revert "Add sudo to IPV6 setup commands for proper permissions" This reverts commit 025cc0c. * Remove `add-apv6` action from `Build on Linux (python_lib)` This doesn't work because of permission issues. * Stop using old ubuntu version (#37870) Co-authored-by: Andrei Litvin <[email protected]> --------- Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates on top of #38819 to enable IPV6 again.
Changes:
Testing
Local tests seem to indicate these changes are ok.
Will need CI to validate that REPL tests pass