-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(cli): [BREAKING] remove custom yarn logic #25457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
jkomyno
commented
Oct 18, 2024
aqrln
reviewed
Oct 29, 2024
...ges/internals/src/get-generators/generatorResolvers/prisma-client-js/prismaClientResolver.ts
Show resolved
Hide resolved
- fix #25478 `prisma version --json` should not contain non-json string.
CodSpeed Performance ReportMerging #25457 will not alter performanceComparing Summary
|
c9f3883
to
9189c93
Compare
jkomyno
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
Fixes https://github.com/prisma/team-orm/issues/1326, closes ORM-310.
This is for Prisma 6. We're merging this to
feat/next
until we're ready for rebasing that branch intomain
.This PR gets rid of custom
schema.prisma
detection logic foryarn
.Some considerations:
yarn
was something of a unique scenario; for instance, we've never had any customschema.prisma
lookup logic forpnpm
workspacesPrisma will no longer be able to automatically to climb up the workspace tree to find the
schema.prisma
file defined in the root of the workspace. E.g., say that the directory tree isand the root
package.json
iswhich contains the
prisma.schema
attribute.If we're running
prisma generate
in./packages/a
, we'll no longer climb up to./package.json
, read itsprisma.schema
attribute, and use./db/schema.prisma
as the default argument forprisma generate --schema <PRISMA_SCHEMA_PATH>
.