Skip to content

fix(fetch-engine): use rename syscall to ensure atomic moves #25129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix(fetch-engine): use rename syscall to ensure atomic moves #25129

merged 3 commits into from
Oct 28, 2024

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Aug 31, 2024 •
edited by aqrln
Loading

Fixes #19124

the Linux manpage (man 2 rename) has this to say on the topic on atomicity:

If newpath already exists, it will be atomically replaced, so that there is no point at which another process attempting to access newpath will find it missing

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #25129 will not alter performance

Comparing tmm1:main (85ff269) with main (7a5c965)

Summary

✅ 3 untouched benchmarks

@tmm1 tmm1 mentioned this pull request Aug 31, 2024
Closed
@tmm1
Copy link
Contributor Author

tmm1 commented Sep 9, 2024

Friendly ping

@tmm1 tmm1 mentioned this pull request Sep 26, 2024
Open
aqrln
aqrln approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aqrln aqrln added this to the 5.21.0 milestone Sep 26, 2024
@aqrln aqrln mentioned this pull request Sep 26, 2024
Closed
@aqrln aqrln self-assigned this Sep 26, 2024
@aqrln aqrln merged commit 07ed045 into prisma:main Oct 28, 2024
425 checks passed
@aqrln aqrln modified the milestones: 5.21.0, 5.22.0 Oct 28, 2024
jkomyno added a commit that referenced this pull request Oct 31, 2024
@jkomyno @tmm1
@Takur0 @hinaloe
feat(cli): [BREAKING] remove custom yarn logic (#25457)
b0ca0f7 
* feat(cli): [BREAKING] remove custom yarn logic

* test(internals): update snapshots

* chore(internals): get rid of unused fixtures

* fix(fetch-engine): use rename syscall to ensure atomic moves (#25129)

* fix(adapter-d1): throws Error when string column contains any ISO date (#25483)

* fix(cli): `prisma version --json` suppress dotenv message (#25535)

- fix #25478

`prisma version --json` should not contain non-json string.

* chore: removed unused file

* chore: restore yarn detection logic for Windows

---------

Co-authored-by: Aman Karmani <[email protected]>
Co-authored-by: Yamashiro Takuro <[email protected]>
Co-authored-by: Hinaloe <[email protected]>
@jkomyno jkomyno mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aqrln aqrln aqrln approved these changes

Assignees

@aqrln aqrln

Labels

None yet

Projects

None yet

Milestone

5.22.0

Development

Successfully merging this pull request may close these issues.

Prisma generate randomly fails on Ubuntu due to missing internal .so libquery_engine-debian-openssl-1.1.x.so.node

3 participants

@tmm1 @CLAassistant @aqrln