fix(engine-core): connect to QE binary by IPv4 loopback address #10211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless a different IP or hostname is specified using the `--host` command-line option, the query engine server binds to `127.0.0.1`: * https://github.com/prisma/prisma-engines/blob/af993bb6d5c28f94e4ab70f68ff69364b628af97/query-engine/query-engine/src/opt.rs#L44-L46 * https://github.com/prisma/prisma-engines/blob/af993bb6d5c28f94e4ab70f68ff69364b628af97/query-engine/query-engine/src/server/mod.rs#L93 The BinaryEngine client tried to connect to the query engine server using the `localhost` hostname, which normally resolves to either `127.0.0.1` or `::1` (and in exotic cases might even resolve to something completely different). When `localhost` resolved to the IPv6 loopback address (which seems to be usually the case with Node.js 17), the client couldn't connect because the query engine server doesn't bind to it. This commit changes `localhost` to `127.0.0.1` to avoid this error. Fixes #9903
aqrln
commented
Nov 11, 2021
millsp
approved these changes
Nov 11, 2021
|
@aqrln looks good! Harshit was unable to reproduce though #9903 (comment) Did you get to a reproduction? |
|
@Jolg42 on my machine it's reproducible, yes |
|
Minimal reproduction: |
Jolg42
approved these changes
Nov 11, 2021
JaavLex
added a commit
to epfl-si/lhd.graphql
that referenced
this pull request
Mar 1, 2022
- Improves security. - Works around mistakenly using iPV6 instead of iPV4 (prisma/prisma#10211 * That bug is still somewhat unfixed, it's just a workaround like said earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless a different IP or hostname is specified using the
--hostcommand-line option, the query engine server binds to
127.0.0.1:The BinaryEngine client tried to connect to the query engine server
using the
localhosthostname, which normally resolves to either127.0.0.1or::1(and in exotic cases might even resolve tosomething completely different). When
localhostresolved to the IPv6loopback address (which seems to be usually the case with Node.js 17),
the client couldn't connect because the query engine server doesn't bind
to it. This commit changes
localhostto127.0.0.1to avoid thiserror.
Fixes #9903