Skip to content

Conversation

@DanrwAU
Copy link
Member

@DanrwAU DanrwAU commented Jan 22, 2021

Description

Removes the small screen detection from the Alias column to show this when iPhoneX in landscape mode.

Will still hide the column when overall device width is lower than 768px.

Fixes #438

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In production .... duh

Blisk browser to emulate iPhoneX

Portrait
image

Landscape
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated changelog.md with changes made

Fixes alias not showing when iPhoneX in landscape mode
@DanrwAU DanrwAU added this to the 0.3.11 milestone Jan 22, 2021
@DanrwAU DanrwAU self-assigned this Jan 22, 2021
@DanrwAU DanrwAU changed the base branch from master to develop January 22, 2021 13:47
@DanrwAU DanrwAU requested a review from a team January 22, 2021 14:06
@marshyonline marshyonline merged commit fc9052d into develop Jan 22, 2021
@DanrwAU DanrwAU deleted the fix438 branch January 23, 2021 05:46
@DanrwAU DanrwAU mentioned this pull request Jan 23, 2021
5 tasks
@marshyonline marshyonline mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Columns not working on iPhone X

4 participants