Skip to content

Conversation

@marshyonline
Copy link
Member

Changes

eopo and others added 30 commits May 17, 2020 19:43
Changed filtering from message list to said new filter, when invoked from alias name cell
Added link to said new filtering from alias list

Signed-off-by: eopo <[email protected]>
Support for US/CA SAME EAS Messages - Purely Client side
@marshyonline marshyonline requested a review from s3m1s0n1c May 27, 2021 08:52
DanrwAU
DanrwAU previously approved these changes May 29, 2021
Copy link
Member

@DanrwAU DanrwAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done basic functionality testing (Login/Message Post) on SQLIte and MySQL and it looks good.
I'll do the release and upgrade one of my instances, see if it breaks i guess 🤣

microsoldering1 and others added 2 commits June 4, 2021 01:17
correct issue where long words result in unintended layout
@DanrwAU DanrwAU changed the title Release V0.0.11 Release V0.3.11 Jun 4, 2021
@marshyonline
Copy link
Member Author

Let get this bad boy aproved and shipped

@e-bits
Copy link
Contributor

e-bits commented Jun 25, 2021

Please include #477, before releasing 0.3.11 Thanks.

@AndrewJ1990
Copy link

Sorry for the questions but new to all this: Has this been released it? It fixes one of my problem. Otherwise how can I update to this version?

@e-bits
Copy link
Contributor

e-bits commented Sep 22, 2021

Hi @AndrewJ1990, no currently it's not released. If you would like to test the latest version you need to switch to develop branch and build it yourself.

@DanrwAU
Copy link
Member

DanrwAU commented Oct 4, 2021

@davidmckenzie @marshyonline are you guys happy with this release as is? I'll do a release later tonight/tomorrow if so :)

@SloCompTech
Copy link
Contributor

Was db.raw() tested with supported dbs ?

@DanrwAU
Copy link
Member

DanrwAU commented Oct 4, 2021

Was db.raw() tested with supported dbs ?

It's been used before without issue, but it's been a while so i dont recall the specifics... why do you ask?

@SloCompTech
Copy link
Contributor

SloCompTech commented Oct 4, 2021

Because db.raw() is used to insert raw SQL statements (or parts) which aren't always supported by all databases which could lead to problems if not checked and tested.

@DanrwAU
Copy link
Member

DanrwAU commented Oct 4, 2021

Because db.raw() is used to insert raw SQL statements (or parts) which aren't always supported by all databases which could lead to problems if not checked and tested.

I think any usage of it is wrapped in checking if statements to ensure it is used on the correct db type.

@DanrwAU
Copy link
Member

DanrwAU commented Oct 4, 2021

Because db.raw() is used to insert raw SQL statements (or parts) which aren't always supported by all databases which could lead to problems if not checked and tested.

I think any usage of it is wrapped in checking if statements to ensure it is used on the correct db type.

A quick search shows all usage of db.raw is wrapped in an if statement checking the db type 😉

@SloCompTech
Copy link
Contributor

Ok

@davidmckenzie
Copy link
Member

Yep all good here, merge away :)

@DanrwAU DanrwAU merged commit 3ed0e65 into master Oct 17, 2021
@DanrwAU
Copy link
Member

DanrwAU commented Oct 17, 2021

Released... Yolo.

Log any bugs you find ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.