Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Apr 3, 2023

Stack from ghstack (oldest at bottom):

This is a quick attempt to utilize torch.func.functionalize for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will likely
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98246

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 7afbd38:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 3, 2023
@BowenBao BowenBao added the OSS contribution wanted PR from open source contributors welcome to solve this issue. label Apr 3, 2023
…t exporter"


This is a quick attempt to utilize `torch.func.functionalize` for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will likely
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 3, 2023
…t exporter"


This is a quick attempt to utilize `torch.func.functionalize` for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will ~~likely~~
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 3, 2023
…t exporter"


This is a quick attempt to utilize `torch.func.functionalize` for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will ~~likely~~
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 4, 2023
…t exporter"


This is a quick attempt to utilize `torch.func.functionalize` for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will ~~likely~~
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 5, 2023
…alization' for torchscript exporter"


This is a quick attempt to utilize `torch.func.functionalize` for torchscript based
onnx exporter. So far it works for the simple mutation test case, but one would
expect a lot of issues and edge cases with more complicated models. I will ~~likely~~
not follow up on this to completion, but feel free to use this PR as a starting point if
you found this an interesting feature to add!

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 5, 2023
@github-actions github-actions bot closed this Jul 5, 2023
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/224/head branch August 5, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source OSS contribution wanted PR from open source contributors welcome to solve this issue. release notes: onnx torch.onnx related changes that should show up in the release notes Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants