[ONNX] Introduce 'Functionalization' for fx exporter #98245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98245
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit f64b71b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
BowenBao
commented
Apr 3, 2023
| @@ -196,6 +196,18 @@ def forward(self, x, y): | |||
| DynamicAdd(), (x, y), additional_test_inputs=[(input_x, input_y)] | |||
| ) | |||
|
|
|||
| def test_mutation(self): | |||
There was a problem hiding this comment.
To be deduplicated once dynamic tests are parameterized.
[ghstack-poisoned]
[ghstack-poisoned]
<img src="https://user-images.githubusercontent.com/9376104/229648898-7e85efc8-143f-42f9-93e0-298a8f86c0a1.png" width="80%" height="80%"> [ghstack-poisoned]
BowenBao
commented
Apr 4, 2023
| @@ -2,6 +2,7 @@ | |||
| from typing import Any, Callable, Mapping, Sequence | |||
|
|
|||
| import torch._ops | |||
| import torch.fx | |||
There was a problem hiding this comment.
for intellisense/pylance not complaining "fx" is not a known member of module "torch" for torch.fx.GraphModule.
justinchuby
reviewed
Apr 5, 2023
wschin
reviewed
Apr 5, 2023
wschin
reviewed
Apr 5, 2023
<img src="https://user-images.githubusercontent.com/9376104/229648898-7e85efc8-143f-42f9-93e0-298a8f86c0a1.png" width="80%" height="80%"> [ghstack-poisoned]
titaiwangms
reviewed
Apr 5, 2023
wschin
approved these changes
Apr 6, 2023
…on' for fx exporter" <img src="https://user-images.githubusercontent.com/9376104/229648898-7e85efc8-143f-42f9-93e0-298a8f86c0a1.png" width="80%" height="80%"> [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):