[quant][pt2e] Add reference representation for quantized max_pool2d #105708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105708
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit d33cf10: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 21, 2023
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 22, 2023
kimishpatel
requested changes
Jul 24, 2023
| quantizer.set_global(operator_config) | ||
| m_eager = TestHelperModules.ConvMaxPool2d().eval() | ||
|
|
||
| example_inputs = (torch.randn(1, 2, 2, 2),) |
There was a problem hiding this comment.
Is the replacement failing here because of "burnt" in scalars issue?
There was a problem hiding this comment.
the replacement succeeds in the test (checked locally), do you mean why the replacement doesn't work before we have replace_literals_with_placeholders workaround?
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
andrewor14
reviewed
Aug 2, 2023
andrewor14
approved these changes
Aug 2, 2023
kimishpatel
reviewed
Aug 2, 2023
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ax_pool2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 4, 2023
…_pool2d (#105709) Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_adaptive_avg_pool2d Although right now it is not really testing things since there is some problem with dynamo export Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: #105709 Approved by: https://github.com/andrewor14 ghstack dependencies: #105708
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
…_pool2d (pytorch#105709) Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_adaptive_avg_pool2d Although right now it is not really testing things since there is some problem with dynamo export Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#105709 Approved by: https://github.com/andrewor14 ghstack dependencies: pytorch#105708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8
Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_representation_maxpool2d
Although right now it is not really testing things since there is some problem with dynamo export
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: