[quant][pt2e] Add reference representation for quantized conv2d #105784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105784
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6b3623b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 21, 2023
jerryzh168
added a commit
that referenced
this pull request
Jul 22, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 020000c Pull Request resolved: #105784
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jul 24, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 94e3440 Pull Request resolved: #105784
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jul 24, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b4b33d8 Pull Request resolved: #105784
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
kimishpatel
requested changes
Aug 3, 2023
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 4, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c953a3f Pull Request resolved: #105784
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 4, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 938366d Pull Request resolved: #105784
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 7, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2c98ccf Pull Request resolved: #105784
kimishpatel
approved these changes
Aug 8, 2023
I have tested these locally and fixed the bias stuff as well, will probably enable the tests in CI soon since I didn't find it is timing out in sandcastle recently. what is the not addressed comment are you referring to btw? |
…onv2d" Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 9, 2023
Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 04fabef Pull Request resolved: #105784
|
@pytorchbot merge |
|
TODO: we need to support autograd for out_dtype op so that user don't need to use torch.no_grad to run the quantized model. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
…rch#105784) Summary: Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8 Test Plan: python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel Although right now it is not really testing things since there is some problem with dynamo export Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#105784 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#105783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Implementing reference representation for quantized ops we decided in https://docs.google.com/document/d/17h-OEtD4o_hoVuPqUFsdm5uo7psiNMY8ThN03F9ZZwg/edit#heading=h.ov8z39149wy8
Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_representation_quantize_dequantize_per_channel
Although right now it is not really testing things since there is some problem with dynamo export
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: