Skip to content

Enable Leak Sanitizer #154584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable Leak Sanitizer #154584

wants to merge 3 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 29, 2025 •
edited
Loading

It enables Leak Sanitizer and also provides a suppression file.
Before LSAN, the longest ASAN job is around 52min; after LSAN the average ASAN job time is more than 2h 30min.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@cyyever cyyever requested review from a team, albanD and soulitzer as code owners May 29, 2025 02:53
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154584

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 12a702e with merge base c699668 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented May 29, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 29, 2025
@cyyever cyyever marked this pull request as draft May 29, 2025 11:15
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 17, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased lsan2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout lsan2 && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 18, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased lsan2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout lsan2 && git pull --rebase)

albanD
albanD reviewed Jun 20, 2025
View reviewed changes
torch/csrc/autograd/VariableTypeManual.cpp Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that a leak?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous run reported possible leaks here

torch/csrc/autograd/variable.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, are these leaks?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous run reported possible leaks here, should be false positive. Nevertheless, the move avoids one copy operation.

@cyyever cyyever marked this pull request as ready for review June 21, 2025 11:10
@cyyever cyyever force-pushed the lsan2 branch 4 times, most recently from 146093b to 7448128 Compare June 22, 2025 00:33
@cyyever cyyever requested a review from ezyang June 22, 2025 10:08
ezyang
ezyang previously approved these changes Jun 23, 2025
View reviewed changes
@ezyang
Copy link
Contributor

ezyang commented Jun 23, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here