Enable Leak Sanitizer

cyyever · pytorchmergebot · commit c54c654d66cb · 2025-06-17T06:55:07.000Z
diff --git a/.ci/pytorch/test.sh b/.ci/pytorch/test.sh
@@ -216,11 +216,13 @@ fi
 # if you're not careful.  Check this if you made some changes and the
 # ASAN test is not working
 if [[ "$BUILD_ENVIRONMENT" == *asan* ]]; then
-    export ASAN_OPTIONS=detect_leaks=0:symbolize=1:detect_stack_use_after_return=true:strict_init_order=true:detect_odr_violation=1:detect_container_overflow=0:check_initialization_order=true:debug=true
+    export ASAN_OPTIONS=detect_leaks=1:symbolize=1:detect_stack_use_after_return=true:strict_init_order=true:detect_odr_violation=1:detect_container_overflow=0:check_initialization_order=true:debug=true:fast_unwind_on_malloc=1
     if [[ "$BUILD_ENVIRONMENT" == *cuda* ]]; then
         export ASAN_OPTIONS="${ASAN_OPTIONS}:protect_shadow_gap=0"
     fi
     export UBSAN_OPTIONS=print_stacktrace=1:suppressions=$PWD/ubsan.supp
+    # Suppress some hard to solve indirect leaks
+    export LSAN_OPTIONS="suppressions=$PWD/lsan.supp"
     export PYTORCH_TEST_WITH_ASAN=1
     export PYTORCH_TEST_WITH_UBSAN=1
     # TODO: Figure out how to avoid hard-coding these paths
diff --git a/lsan.supp b/lsan.supp
@@ -0,0 +1,30 @@
+leak:pybind11::cpp_function
+leak:PyMem_RawMalloc
+leak:unicode_resize
+leak:PyObject_Malloc
+leak:PyByteArray_Resize
+leak:numpy
+leak:list_append
+leak:unicodeobject
+leak:obmalloc
+leak:gcmodule
+leak:listobject
+leak:bytesobject
+leak:PyThread_allocate_lock
+leak:sccache
+leak:rustc-1.61.0
+leak:gcc/x86_64-linux-gnu/11
+leak:x86_64-linux-gnu-gcc-11
+leak:libbfd
+leak:x86_64-linux-gnu-ld.bfd
+leak:git
+leak:libio
+leak:unknown module
+leak:g++
+leak:conda-linux-gnu-ld
+leak:crypto
+leak:torch::detail::(anonymous namespace)::get_set_cached_attr
+leak:torch::jit::tensorexpr::TensorExprKernel::preAllocIntermediateBufs
+leak:optree
+leak:python
+leak:torch::tensors::initialize_aten_types
diff --git a/torch/csrc/Module.cpp b/torch/csrc/Module.cpp
@@ -235,7 +235,7 @@ static PyObject* THPModule_initExtension(
   END_HANDLE_TH_ERRORS
 }
 
-// The idea behind these two functions is to make it easy to test if we are
+// The idea behind these functions is to make it easy to test if we are
 // built with ASAN: they're designed not to crash if ASAN is not enabled, but
 // to trigger ASAN if it is enabled.  This lets us run a "canary" tests which
 // checks if our build environment is misconfigured.
diff --git a/torch/csrc/autograd/VariableTypeManual.cpp b/torch/csrc/autograd/VariableTypeManual.cpp
@@ -456,7 +456,7 @@ static Tensor detach(c10::DispatchKeySet ks, const Tensor& self) {
   // NB: we can't make detach() a normal view operator because the codegen
   // generates allow_tensor_metadata_change = True for them. In the future we
   // should have an option for this in the codegen.
-  auto result = as_view(
+  return as_view(
       /* base */ self,
       /* output */ out,
       /* is_bw_differentiable */ false,
@@ -465,8 +465,6 @@ static Tensor detach(c10::DispatchKeySet ks, const Tensor& self) {
       /* rev_view_func */ nullptr,
       /* creation_meta */ CreationMeta::DEFAULT,
       /*allow_tensor_metadata_change=*/false);
-
-  return result;
 }
 
 static Tensor _fw_primal(
diff --git a/torch/csrc/autograd/variable.h b/torch/csrc/autograd/variable.h
@@ -844,7 +844,7 @@ inline Variable make_variable_non_differentiable_view(
         /*version_counter=*/impl::version_counter(base),
         /*allow_tensor_metadata_change=*/allow_tensor_metadata_change);
     data_impl_copy->set_autograd_meta(nullptr);
-    return Variable(data_impl_copy);
+    return Variable(std::move(data_impl_copy));
   }
   return Variable();
 }
@@ -903,7 +903,7 @@ inline Variable make_variable(
         /*allow_tensor_metadata_change=*/allow_tensor_metadata_change);
     data_impl_copy->set_autograd_meta(std::make_unique<AutogradMeta>(
         data_impl_copy.get(), false, std::move(gradient_edge)));
-    return Variable(data_impl_copy);
+    return Variable(std::move(data_impl_copy));
   }
   return Variable();
 }

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ static PyObject* THPModule_initExtension(`
`235`	`235`	`END_HANDLE_TH_ERRORS`
`236`	`236`	`}`
`237`	`237`
`238`		`-// The idea behind these two functions is to make it easy to test if we are`
	`238`	`+// The idea behind these functions is to make it easy to test if we are`
`239`	`239`	`// built with ASAN: they're designed not to crash if ASAN is not enabled, but`
`240`	`240`	`// to trigger ASAN if it is enabled. This lets us run a "canary" tests which`
`241`	`241`	`// checks if our build environment is misconfigured.`
Original file line number	Diff line number	Diff line change
`@@ -844,7 +844,7 @@ inline Variable make_variable_non_differentiable_view(`
`844`	`844`	`/version_counter=/impl::version_counter(base),`
`845`	`845`	`/allow_tensor_metadata_change=/allow_tensor_metadata_change);`
`846`	`846`	`data_impl_copy->set_autograd_meta(nullptr);`
`847`		`- return Variable(data_impl_copy);`
	`847`	`+ return Variable(std::move(data_impl_copy));`
`848`	`848`	`}`
`849`	`849`	`return Variable();`
`850`	`850`	`}`
`@@ -903,7 +903,7 @@ inline Variable make_variable(`
`903`	`903`	`/allow_tensor_metadata_change=/allow_tensor_metadata_change);`
`904`	`904`	`data_impl_copy->set_autograd_meta(std::make_unique<AutogradMeta>(`
`905`	`905`	`data_impl_copy.get(), false, std::move(gradient_edge)));`
`906`		`- return Variable(data_impl_copy);`
	`906`	`+ return Variable(std::move(data_impl_copy));`
`907`	`907`	`}`
`908`	`908`	`return Variable();`
`909`	`909`	`}`