Skip to content

Conversation

@lit-robot
Copy link
Member

@lit-robot lit-robot commented Jan 2, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/[email protected]

Minor Changes

  • #4755 25962bf5 Thanks @kyubisation! - Implement SSR event handling and an optional flag globalThis.litSsrCallConnectedCallback to call connectedCallback during SSR, if set to true.

Patch Changes

@lit-labs/[email protected]

Minor Changes

  • #4755 25962bf5 Thanks @kyubisation! - Implement SSR event handling and an optional flag globalThis.litSsrCallConnectedCallback to call connectedCallback during SSR, if set to true.

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

  • #4888 3eb64fbf - Move Slots type assertion to fix type errors on generated components.

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

  • #4836 05691ba4 Thanks @maxpatiiuk! - Improve type inference of tuples returned by the args function being used as task function parameter.

@lit-internal/[email protected]

Patch Changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +11% (-0.88ms - +1.47ms)
    this-change vs tip-of-tree

render

  • this-change: 43.96ms - 53.03ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-0.33ms - +0.87ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +3% (-0.14ms - +1.03ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -39% - +4% (-26.78ms - +3.81ms)
    this-change vs tip-of-tree

update

  • this-change: 505.75ms - 510.55ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-1.41ms - +2.78ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.87ms - +1.58ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.42ms - +4.68ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 502.46ms - 506.39ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-8.78ms - +0.09ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
43.96ms - 53.03ms-

update

VersionAvg timevs
505.75ms - 510.55ms-

update-reflect

VersionAvg timevs
502.46ms - 506.39ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.59ms - 20.45ms-unsure 🔍
-2% - +4%
-0.33ms - +0.87ms
unsure 🔍
-1% - +4%
-0.26ms - +0.84ms
tip-of-tree
tip-of-tree
19.34ms - 20.17msunsure 🔍
-4% - +2%
-0.87ms - +0.33ms
-unsure 🔍
-3% - +3%
-0.52ms - +0.56ms
previous-release
previous-release
19.38ms - 20.08msunsure 🔍
-4% - +1%
-0.84ms - +0.26ms
unsure 🔍
-3% - +3%
-0.56ms - +0.52ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
40.91ms - 43.60ms-unsure 🔍
-3% - +7%
-1.41ms - +2.78ms
unsure 🔍
-1% - +9%
-0.31ms - +3.55ms
tip-of-tree
tip-of-tree
39.97ms - 43.17msunsure 🔍
-7% - +3%
-2.78ms - +1.41ms
-unsure 🔍
-3% - +8%
-1.18ms - +3.04ms
previous-release
previous-release
39.26ms - 42.01msunsure 🔍
-8% - +1%
-3.55ms - +0.31ms
unsure 🔍
-7% - +3%
-3.04ms - +1.18ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.65ms - 14.15ms-unsure 🔍
-7% - +11%
-0.88ms - +1.47ms
unsure 🔍
-4% - +14%
-0.45ms - +1.76ms
tip-of-tree
tip-of-tree
12.20ms - 14.00msunsure 🔍
-11% - +6%
-1.47ms - +0.88ms
-unsure 🔍
-7% - +12%
-0.85ms - +1.56ms
previous-release
previous-release
11.94ms - 13.55msunsure 🔍
-13% - +3%
-1.76ms - +0.45ms
unsure 🔍
-12% - +6%
-1.56ms - +0.85ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
35.58ms - 36.54ms-unsure 🔍
-0% - +3%
-0.14ms - +1.03ms
unsure 🔍
-4% - +3%
-1.61ms - +1.03ms
tip-of-tree
tip-of-tree
35.28ms - 35.95msunsure 🔍
-3% - +0%
-1.03ms - +0.14ms
-unsure 🔍
-5% - +1%
-2.00ms - +0.54ms
previous-release
previous-release
35.13ms - 37.57msunsure 🔍
-3% - +4%
-1.03ms - +1.61ms
unsure 🔍
-2% - +6%
-0.54ms - +2.00ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
75.38ms - 78.19ms-unsure 🔍
-2% - +2%
-1.87ms - +1.58ms
unsure 🔍
-2% - +3%
-1.69ms - +1.92ms
tip-of-tree
tip-of-tree
75.93ms - 77.93msunsure 🔍
-2% - +2%
-1.58ms - +1.87ms
-unsure 🔍
-2% - +2%
-1.26ms - +1.76ms
previous-release
previous-release
75.54ms - 77.81msunsure 🔍
-2% - +2%
-1.92ms - +1.69ms
unsure 🔍
-2% - +2%
-1.76ms - +1.26ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
43.54ms - 63.86ms-unsure 🔍
-39% - +4%
-26.78ms - +3.81ms
unsure 🔍
-34% - +13%
-21.41ms - +8.44ms
tip-of-tree
tip-of-tree
53.75ms - 76.62msunsure 🔍
-10% - +53%
-3.81ms - +26.78ms
-unsure 🔍
-19% - +36%
-10.82ms - +20.82ms
previous-release
previous-release
49.25ms - 71.12msunsure 🔍
-17% - +41%
-8.44ms - +21.41ms
unsure 🔍
-31% - +16%
-20.82ms - +10.82ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
513.40ms - 520.75ms-unsure 🔍
-1% - +1%
-6.42ms - +4.68ms
unsure 🔍
-1% - +1%
-7.62ms - +3.42ms
tip-of-tree
tip-of-tree
513.79ms - 522.10msunsure 🔍
-1% - +1%
-4.68ms - +6.42ms
-unsure 🔍
-1% - +1%
-7.09ms - +4.63ms
previous-release
previous-release
515.05ms - 523.30msunsure 🔍
-1% - +1%
-3.42ms - +7.62ms
unsure 🔍
-1% - +1%
-4.63ms - +7.09ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
520.66ms - 526.90ms-unsure 🔍
-2% - +0%
-8.78ms - +0.09ms
unsure 🔍
-1% - +1%
-5.30ms - +2.93ms
tip-of-tree
tip-of-tree
524.97ms - 531.28msunsure 🔍
-0% - +2%
-0.09ms - +8.78ms
-unsure 🔍
-0% - +1%
-0.98ms - +7.31ms
previous-release
previous-release
522.28ms - 527.65msunsure 🔍
-1% - +1%
-2.93ms - +5.30ms
unsure 🔍
-1% - +0%
-7.31ms - +0.98ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bumps look good to me.
@lit-internal/[email protected] bump is irrelevant as it is a private package that won't get an npm release but changeset picks it up due to its dependency.

@augustjk augustjk requested a review from rictic January 2, 2025 18:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure in test pipeline seems to happen locally too. i'll take a look later today.

@github-actions github-actions bot force-pushed the changeset-release/main branch from 389f21f to bfcb89d Compare January 3, 2025 22:30
@augustjk augustjk merged commit 935697d into main Jan 10, 2025
9 of 10 checks passed
@augustjk augustjk deleted the changeset-release/main branch January 10, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants