[labs/nextjs] Bump Peer Dependencies for Next 15 Support #4815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d24537c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
Collaborator
justinfagnani
left a comment
There was a problem hiding this comment.
Thanks @JamesIves!
LGTM - wdyt @augustjk ?
justinfagnani
approved these changes
Nov 19, 2024
augustjk
approved these changes
Nov 20, 2024
Member
augustjk
left a comment
There was a problem hiding this comment.
Thanks! This examples seem to work fine with SSR in the new version. Just a couple suggestions to remove the now-invalid next config option.
Co-authored-by: Augustine Kim <[email protected]>
Co-authored-by: Augustine Kim <[email protected]>
Contributor
Author
|
@augustjk @justinfagnani Should be all good to go now |
augustjk
pushed a commit
to maxpatiiuk/lit
that referenced
this pull request
Nov 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4812
Description
Bumps peer dependencies so labs/nextjs works with Next.js 15. Also adds two sample apps for Next.js 15 (one for app router, another for pages) by copying and pasting the v14 samples and running the Next.js updater tool on them.
I took a pass at validating the SSR functionality and everything seemed fine, but would appreciate a sanity check.
Happy to make any changes based on feedback!