fix: Widen range for React types to include React 19 #4865
Conversation
🦋 Changeset detectedLatest commit: d4c471c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This allows using @lit/react with React 19 For lit#4857
33ddfd6 to
8eb79f5
Compare
|
Should this also widen the dependency range in the ssr-react package? |
|
Hi, is there an estimated date when this will be reviewed? Thanks! |
Looks like it should, I added it. |
|
Is @justinfagnani still working on this project or is it somebody else? |
|
I'll bring it up during the community call on Thursday. |
| }, | ||
| "peerDependencies": { | ||
| "@types/react": "17 || 18" | ||
| "@types/react": "17 || 18 || 19" |
There was a problem hiding this comment.
I would expect a few more changes here. Does the package lock need to be regenerated?
There was a problem hiding this comment.
The lock change for ssr-react was apparently missing, added what "npm install" updates
augustjk
left a comment
There was a problem hiding this comment.
Thanks! I do want to explore detect React version and passing props directly to React for >= 19 as described in #4857 (comment) but that can be done as a separate improvement.
This allows using @lit/react with React 19
For #4857