Skip to content

Do not query organizations if manage-realm is not granted #42072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Aug 26, 2025
Merged

Do not query organizations if manage-realm is not granted #42072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make it possible to check for permissions when deciding if a feature … 
…is enabled or not

Do not query organizations if manage-realm is not granted

Closes #41418

Signed-off-by: Pedro Igor <[email protected]>
  • Loading branch information
@pedroigor
pedroigor committed Aug 22, 2025
commit 54320878867e45eaecb15bec2c21bdacf653c780
13 changes: 12 additions & 1 deletion js/apps/admin-ui/src/utils/useIsFeatureEnabled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useServerInfo } from "../context/server-info/ServerInfoProvider";
import { useAccess } from "../context/access/Access";

export enum Feature {
AdminFineGrainedAuthz = "ADMIN_FINE_GRAINED_AUTHZ",
Expand All @@ -20,13 +21,23 @@ export enum Feature {

export default function useIsFeatureEnabled() {
const { features } = useServerInfo();
const { hasAccess } = useAccess();

const hasFeatureAccess = (feature: Feature) => {
switch (feature) {
case Feature.Organizations:
return hasAccess("manage-realm");
default:
return true;
}
};

return function isFeatureEnabled(feature: Feature) {
if (!features) {
return false;
}
return features
.filter((f) => f.enabled)
.filter((f) => f.enabled && hasFeatureAccess(f.name as Feature))
.map((f) => f.name)
.includes(feature);
};
Expand Down
Loading