Do not query organizations if manage-realm is not granted #42072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…is enabled or not Do not query organizations if manage-realm is not granted Closes keycloak#41418 Signed-off-by: Pedro Igor <[email protected]>
martin-kanis
approved these changes
Aug 26, 2025
Contributor
martin-kanis
left a comment
There was a problem hiding this comment.
Thanks @pedroigor. I tested the PR in the admin console and it fixes the problem described in the issue.
I let you decide whether you want another review from someone with deeper UI knowledge.
ahus1
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41418
manage-realmrole to enforce admin access.useIsFeatureEnabledhook is updated to also check permissions when checking if a feature is enabled. That should make the UI also a bit better because theOrganizationssettings in theRealm Settingstab is not even shown if the admin user does not have the required role.