Skip to content

Conversation

@jcaamano
Copy link
Owner

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@jcaamano jcaamano force-pushed the network-gc branch 12 times, most recently from c549687 to 3bb82e5 Compare June 3, 2024 11:45
@jcaamano jcaamano force-pushed the network-gc branch 6 times, most recently from 36a6735 to 9c150c4 Compare June 10, 2024 16:22
@jcaamano jcaamano force-pushed the network-gc branch 6 times, most recently from f561078 to 182b770 Compare July 1, 2024 17:47
@jcaamano jcaamano force-pushed the network-gc branch 3 times, most recently from c9600df to e1f12f9 Compare July 15, 2024 07:45
@jcaamano jcaamano force-pushed the network-gc branch 2 times, most recently from 67373f5 to 4027220 Compare August 5, 2024 16:49
openshift-merge-bot bot and others added 29 commits November 13, 2024 08:11
Signed-off-by: Sascha Grunert <[email protected]>
The dual-stack test was quite broken:

  1. It checked "the IPv6 hostports have been added" after *removing*
     them (which "passed" because it was really only checking "every
     rule that was added to iptables is a rule that we were expecting"
     without checking that "every rule we expected to be added to
     iptables actually did get added").

  2. The expected IPv6 rules were variously wrong anyway (mostly
     incorrect ports, presumably because the test cases were edited at
     one point without also fixing up the expectations, which then
     didn't get caught by the test because it was broken anyway).

  3. One of the test cases tried to map an IPv4 HostIP to an IPv6
     PodIP (which resulted in that case being ignored).

Anyway, rather than having a completely different set of test data for
the dual-stack test, just reuse the existing IPv4 and IPv6 test data
and expectations.

Signed-off-by: Dan Winship <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Ayato Tokubi <[email protected]>
This allows defining a RuntimeHandler with custom
annotations or other fields while inheriting the
runtime type from the default runtime.

This behavior is useful for layered projects
that are not in control of the runtime selection
but need to tweak the specific behavior while
inheriting the node global runtime.

Signed-off-by: Martin Sivak <[email protected]>
Use a common cert-reloader for metrics and streaming endpoints
Bumps the actions group with 2 updates: [codecov/codecov-action](https://github.com/codecov/codecov-action) and [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action).


Updates `codecov/codecov-action` from 4.6.0 to 5.0.1
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@b9fd7d1...3b1354a)

Updates `DavidAnson/markdownlint-cli2-action` from 17.0.0 to 18.0.0
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)
- [Commits](DavidAnson/markdownlint-cli2-action@db43aef...eb5ca3a)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
…tions-b45c5d9ada

build(deps): bump the actions group with 2 updates
Signed-off-by: Sascha Grunert <[email protected]>
A small cleanup to use more modern go standards.

Signed-off-by: Sascha Grunert <[email protected]>
Add the option to be able to fine-tune the pull progress timeout or even
disable it.

Fixes cri-o#8764 and cri-o#8760

Follow-up on: cri-o#7887

Signed-off-by: Sascha Grunert <[email protected]>
Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 5.0.1 to 5.0.2
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@3b1354a...5c47607)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Use `slices.Equal` instead of custom implementation
…tions-130f50e8ca

build(deps): bump codecov/codecov-action from 5.0.1 to 5.0.2 in the actions group
The original PR missed few important bits

- the reload code path was not the only one that loads configs
- an empty RuntimePath has a special meaning and inheriting it
  does not inherit the parent runtime
- golang does a copy during interation, not a reference and the
  updated values were forgotten
- the unit test ignores some of the checks during CI when not
  on a bare metal

This patch fixes all of these and adds better logging
and also tests that actually catch the above mistakes.

Signed-off-by: Martin Sivak <[email protected]>
Update golangci-lint to v1.62.0
Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 5.0.2 to 5.0.4
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@5c47607...985343d)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Use google.golang.org/protobuf instead of gogo
…tions-918c5b3e2d

build(deps): bump codecov/codecov-action from 5.0.2 to 5.0.4 in the actions group
Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `codecov/codecov-action` from 5.0.4 to 5.0.7
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@985343d...015f24e)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
…tions-1bc14e4043

build(deps): bump codecov/codecov-action from 5.0.4 to 5.0.7 in the actions group
Add `--pull-progress-timeout` / `pull_progress_timeout` option
As a last measure to clean up potential stale network resources, call
the network plugin GC on startup referencing pods which were restored
successfully, which should clean up for pods that could not be restored.

Since this is not parallel test friendly, disable GC in tests for the
time being.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.