Add dynamic image pull timeout #7887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45857bd to
7e1adef
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7887 +/- ##
==========================================
- Coverage 48.87% 48.86% -0.01%
==========================================
Files 152 152
Lines 16447 16456 +9
==========================================
+ Hits 8038 8042 +4
- Misses 7433 7437 +4
- Partials 976 977 +1 |
|
/retest |
7e1adef to
afec6c3
Compare
|
/retest |
|
/test ci-e2e |
|
/retest |
We now support a pull context which can actually be cancelled. This way we can combine the pull progress together with a dynamic timeout, which cancels the context if no progress is being made on pull. Signed-off-by: Sascha Grunert <[email protected]>
afec6c3 to
1a377cc
Compare
|
/retest |
|
/test e2e-gcp-ovn |
|
@cri-o/cri-o-maintainers PTAL |
|
I think this would fix #6574 as well |
| // It also checks if progress is being made within a constant timeout. | ||
| // If the timeout is reached because no progress updates have been made, then | ||
| // the cancel function will be called. | ||
| func progressGoRoutine(ctx context.Context, cancel context.CancelFunc, progress <-chan imageTypes.ProgressProperties, remoteCandidateName storage.RegistryImageReference) { |
There was a problem hiding this comment.
nit: maybe consumeImagePullProgress or something?
There was a problem hiding this comment.
Sure, following-up in #7946
|
/lgtm nit can be addressed async, or ignored |
|
/retest |
|
/test e2e-gcp-ovn |
|
/retest-required |
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Apr 2, 2024
Follow-up on cri-o#7887 (comment) Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Jun 6, 2024
This allows to set a pull timeout (currently not used neither by the kubelet nor cri-tools) using the CRI context. Future consumers can then limit the pul not only if no network traffic is available (introduced in \cri-o#7887), but also in a more general way. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Nov 18, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Nov 18, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Nov 18, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Nov 18, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/cri-o
that referenced
this pull request
Nov 25, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
xw19
pushed a commit
to xw19/cri-o
that referenced
this pull request
Dec 4, 2024
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
robbmanes
pushed a commit
to robbmanes/cri-o
that referenced
this pull request
Feb 17, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
robbmanes
pushed a commit
to robbmanes/cri-o
that referenced
this pull request
Feb 18, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Feb 24, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Feb 24, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Feb 24, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Feb 24, 2025
Add the option to be able to fine-tune the pull progress timeout or even disable it. Fixes cri-o#8764 and cri-o#8760 Follow-up on: cri-o#7887 Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We now support a pull context which can actually be cancelled. This way we can combine the pull progress together with a dynamic timeout, which cancels the context if no progress is being made on pull.
Which issue(s) this PR fixes:
Refers to #7885
Special notes for your reviewer:
cc @mrunalp
Does this PR introduce a user-facing change?