Skip to content

fix: snacks inline image broken when use terminal.env() before term detection #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
+8 −2
Merged

fix: snacks inline image broken when use terminal.env() before term detection #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
485e6b2
fix: snacks inline image broken when use terminal.env() before term d…
phanen Oct 26, 2025
6e26361
ci: double wait_time
phanen Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lua/fzf-lua/previewer/builtin.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,11 +1069,16 @@ function Previewer.base:attach_snacks_image_inline()
if not simg
or not self.snacks_image.enabled
or not self.snacks_image.render_inline
or not simg.supports_terminal()
or not simg.terminal.env().placeholders
or vim.b[bufnr].snacks_image_attached then
return
end
if not simg.terminal._terminal then -- detection must be done before terminal.env()
simg.terminal.detect(function() end)
return
end
if not simg.supports_terminal() or not simg.terminal.env().placeholders then
return
end

-- restore default winblend when on unsupport ft
local ft = vim.b[bufnr]._ft
Expand Down
1 change: 1 addition & 0 deletions lua/fzf-lua/test/helpers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ M.new_child_neovim = function()
end

local wait_timeout = (M.IS_LINUX() and 2000 or 5000)
wait_timeout = os.getenv("CI") and wait_timeout * 2 or wait_timeout
--- waits until condition fn evals to true, checking every interval ms
--- times out at timeout ms
---@param condition fun(): boolean
Expand Down