fix: snacks inline image broken when use terminal.env() before term detection #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ibhagwan merged 2 commits into ibhagwan:main from phanen:img-inline-detection

Oct 26, 2025

Contributor

phanen commented Oct 26, 2025

https://github.com/folke/snacks.nvim/blob/43261baf87fdc5f970c12e9a6c795ba8a4e7595c/lua/snacks/image/terminal.lua#L111-L113
Maybe it cached invalid value here.
Fix by terminal.detect() before terminal.env()

phanen added 2 commits

October 26, 2025 11:02


          fix: snacks inline image broken when use terminal.env() before term d…

485e6b2

…etection

https://github.com/folke/snacks.nvim/blob/43261baf87fdc5f970c12e9a6c795ba8a4e7595c/lua/snacks/image/terminal.lua#L111-L113
Maybe it cached invalid value here.
Fix by terminal.detect() before terminal.env()


          ci: double wait_time

6e26361

Owner

ibhagwan commented Oct 26, 2025

ibhagwan merged commit 6bb2a26 into ibhagwan:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet