Actron air add sensor entity type #158154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @JagadishDhanamjayam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds sensor and switch platforms to the Actron Air integration, expanding functionality beyond the existing climate platform. The implementation includes comprehensive diagnostic sensors for the AC system and primary sensors for peripheral devices (battery, temperature, humidity), along with configuration switches for various AC operational modes.
Key Changes
- Added 8 AC system sensors (mostly diagnostic, disabled by default) with one primary sensor (clean filter) enabled by default
- Added 3 peripheral sensors per device (battery, humidity, temperature) that represent zone controller measurements
- Added 4 configuration switches (away mode, continuous fan, quiet mode, turbo mode) with conditional turbo switch based on system support
- Updated quality scale status to reflect new Gold-level features (entity categories, device classes, translations)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/actron_air/sensor.py |
New sensor platform implementation with AC system and peripheral sensors. Has critical bug with entity registration loop placement and issues with entity categorization for peripheral sensors |
homeassistant/components/actron_air/switch.py |
New switch platform for AC configuration modes (away, continuous fan, quiet, turbo) |
tests/components/actron_air/test_sensor.py |
Comprehensive unit tests for sensor platform covering setup and entity properties |
tests/components/actron_air/test_switch.py |
Unit tests for switch platform including conditional entity creation and API call verification |
homeassistant/components/actron_air/strings.json |
Added entity translations for sensors and switches. Contains unused translation entry |
homeassistant/components/actron_air/icons.json |
New file with state-based icon definitions for switches |
homeassistant/components/actron_air/quality_scale.yaml |
Updated to mark entity-related Gold features as complete |
homeassistant/components/actron_air/__init__.py |
Updated PLATFORM list to include new sensor and switch platforms |
zweckj
requested changes
Dec 7, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
JagadishDhanamjayam
suggested changes
Dec 7, 2025
…ntities, and update entity names
Contributor
Author
|
@home-assistant add-label draft |
Contributor
Author
|
Waiting until #158087 is merged to dev before updating this one as there are likely to be merge conflicts |
…nd improve assertions
8 tasks
…and disabled status as done
…on-flow as exempt, and set entity-translations and exception-translations to done
joostlek
requested changes
Dec 20, 2025
- Update climate entities to inherit from ActronAirEntity. - Modify coordinator to use ActronAirStatus. - Enhance sensor entity descriptions and implement value functions. - Adjust quality scale to reflect action-exceptions as todo. - Improve test cases for sensor entities and peripheral sensors.
Contributor
Author
Contributor
Author
|
Cancelling PR -> Will break this into smaller chunks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the sensor entity type to the Actron Air integration. The majority of the A/C sensors are marked as disabled diagnostic sensors and can be enabled by the user if they wish. The only enabled out of the box one is clean filter.
Each peripheral (A/C temperature sensor) is zone assignable, but may have multiple sensors per zone. These are represented as individual objects.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Actron air add sensor entity home-assistant.io#42662
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: