Actron air add sensor entity type #158154

kclif9 · 2025-12-07T05:38:09Z

Proposed change

Adds the sensor entity type to the Actron Air integration. The majority of the A/C sensors are marked as disabled diagnostic sensors and can be enabled by the user if they wish. The only enabled out of the box one is clean filter.

Each peripheral (A/C temperature sensor) is zone assignable, but may have multiple sensors per zone. These are represented as individual objects.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Actron air add sensor entity home-assistant.io#42662
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io
Actron air add sensor entity home-assistant.io#42662

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2025-12-07T05:38:16Z

Hey there @JagadishDhanamjayam, mind taking a look at this pull request as it has been labeled with an integration (actron_air) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of actron_air can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign actron_air Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot

Pull request overview

This PR adds sensor and switch platforms to the Actron Air integration, expanding functionality beyond the existing climate platform. The implementation includes comprehensive diagnostic sensors for the AC system and primary sensors for peripheral devices (battery, temperature, humidity), along with configuration switches for various AC operational modes.

Key Changes

Added 8 AC system sensors (mostly diagnostic, disabled by default) with one primary sensor (clean filter) enabled by default
Added 3 peripheral sensors per device (battery, humidity, temperature) that represent zone controller measurements
Added 4 configuration switches (away mode, continuous fan, quiet mode, turbo mode) with conditional turbo switch based on system support
Updated quality scale status to reflect new Gold-level features (entity categories, device classes, translations)

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`homeassistant/components/actron_air/sensor.py`	New sensor platform implementation with AC system and peripheral sensors. Has critical bug with entity registration loop placement and issues with entity categorization for peripheral sensors
`homeassistant/components/actron_air/switch.py`	New switch platform for AC configuration modes (away, continuous fan, quiet, turbo)
`tests/components/actron_air/test_sensor.py`	Comprehensive unit tests for sensor platform covering setup and entity properties
`tests/components/actron_air/test_switch.py`	Unit tests for switch platform including conditional entity creation and API call verification
`homeassistant/components/actron_air/strings.json`	Added entity translations for sensors and switches. Contains unused translation entry
`homeassistant/components/actron_air/icons.json`	New file with state-based icon definitions for switches
`homeassistant/components/actron_air/quality_scale.yaml`	Updated to mark entity-related Gold features as complete
`homeassistant/components/actron_air/__init__.py`	Updated PLATFORM list to include new sensor and switch platforms

homeassistant/components/actron_air/sensor.py

homeassistant/components/actron_air/strings.json

homeassistant/components/actron_air/sensor.py

homeassistant/components/actron_air/switch.py

homeassistant/components/actron_air/quality_scale.yaml

homeassistant/components/actron_air/sensor.py

home-assistant · 2025-12-07T11:24:08Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

homeassistant/components/actron_air/__init__.py

…ntities, and update entity names

kclif9 · 2025-12-16T08:38:14Z

@home-assistant add-label draft

kclif9 · 2025-12-16T08:39:00Z

Waiting until #158087 is merged to dev before updating this one as there are likely to be merge conflicts

…nd improve assertions

…and disabled status as done

…on-flow as exempt, and set entity-translations and exception-translations to done

joostlek · 2025-12-20T08:49:39Z

homeassistant/components/actron_air/entity.py

+from .coordinator import ActronAirSystemCoordinator
+
+
+class ActronAirAcSensor(CoordinatorEntity[ActronAirSystemCoordinator]):


Why is this only a base class for the sensor and why don't we create a base for all other entity types?

joostlek · 2025-12-20T08:50:00Z

homeassistant/components/actron_air/entity.py

+        if hasattr(peripheral, "zones") and len(peripheral.zones) == 1:
+            zone = peripheral.zones[0]
+            if hasattr(zone, "title") and zone.title:


why would we use hasattr here?

joostlek · 2025-12-20T08:50:18Z

homeassistant/components/actron_air/quality_scale.yaml

+  action-exceptions:
+    status: exempt
+    comment: This integration does not have custom service actions.


No you do have climate and switch actions, which are also considered actions

joostlek · 2025-12-20T08:50:31Z

homeassistant/components/actron_air/sensor.py

+    ActronAirSensorEntityDescription(
+        key="clean_filter",
+        translation_key="clean_filter",
+    ),


What can the state be?

joostlek · 2025-12-20T08:50:39Z

homeassistant/components/actron_air/sensor.py

+    ActronAirSensorEntityDescription(
+        key="defrost_mode",
+        translation_key="defrost_mode",
+        entity_registry_enabled_default=False,
+    ),


What can the state be?

joostlek · 2025-12-20T08:50:46Z

homeassistant/components/actron_air/sensor.py

+    ActronAirSensorEntityDescription(
+        key="compressor_mode",
+        translation_key="compressor_mode",
+        entity_registry_enabled_default=False,
+    ),


What can the state be?

joostlek · 2025-12-20T08:50:57Z

homeassistant/components/actron_air/sensor.py

+    ActronAirSensorEntityDescription(
+        key="compressor_speed",
+        translation_key="compressor_speed",
+        native_unit_of_measurement="RPM",


I believe we have a constant for this unit of measurement

joostlek · 2025-12-20T08:51:43Z

homeassistant/components/actron_air/sensor.py

+        return getattr(
+            self.coordinator.data,
+            self.entity_description.attribute_name or self.entity_description.key,
+            None,
+        )


Instead of using getattr, can we extend the SensorEntityDescription and add a value_fn to fetch the data? That way it's also type safe and we don't have to use an or here

joostlek · 2025-12-20T08:52:46Z

tests/components/actron_air/test_sensor.py

+async def _create_coordinator(
+    hass: HomeAssistant, peripherals: list[MockPeripheral]
+) -> ActronAirSystemCoordinator:
+    """Create a coordinator instance backed by mocked API data."""
+    config_entry = MockConfigEntry(domain=DOMAIN, data={})
+    api = MagicMock()
+    api.update_status = AsyncMock()
+    api.state_manager = MagicMock()
+
+    ac_system = SimpleNamespace(
+        system_name="NEO_23C04269",
+        master_wc_model="NTW-100",
+        master_wc_firmware_version="1.0.0",
+    )
+
+    status = SimpleNamespace(
+        ac_system=ac_system,
+        peripherals=peripherals,
+        clean_filter=False,
+        defrost_mode=False,
+        compressor_chasing_temperature=24.0,
+        compressor_live_temperature=23.5,
+        compressor_mode="cooling",
+        compressor_speed=50,
+        compressor_power=1500,


We shouldn't create our own coordinator in the tests. Instead, patch the library to return what we expect and then make HA setup the integration.

I think we should add such peripherals to the mock we have in conftest.py

kclif9 and others added 10 commits December 6, 2025 03:45

Add switch entity platform

95ad48e

Merge branch 'dev' into Actron-Air-Add-Switch-Entity-Type

fb71911

fix copilot suggestions

5a5d3fb

wip

d4fcdbe

wip

93f41d9

wip

2f36d64

fix state class

14f6803

mark completed items as done

7f098c3

update units of measurement

df741be

fix state classes

63ce89f

Copilot AI review requested due to automatic review settings December 7, 2025 05:38

home-assistant bot added cla-signed has-tests integration: actron_air new-feature new-platform quality-scale by-code-owner Quality Scale: bronze labels Dec 7, 2025

Copilot started reviewing on behalf of kclif9 December 7, 2025 05:38 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

Merge branch 'dev' into Actron-Air-Add-Sensor-Entity-Type

df1cc6d

zweckj requested changes Dec 7, 2025

View reviewed changes

home-assistant bot marked this pull request as draft December 7, 2025 11:24

JagadishDhanamjayam suggested changes Dec 7, 2025

View reviewed changes

homeassistant/components/actron_air/__init__.py Show resolved Hide resolved

Refactor Actron Air integration: remove switch platform, add sensor e…

33d30c4

…ntities, and update entity names

kclif9 and others added 4 commits December 16, 2025 08:39

update PR with recent changes to avoid merge conflicts

8a1488c

fix what will be merge conflicts when home-assistant#158087 is merged

bc06cd6

Merge branch 'dev' into Actron-Air-Add-Sensor-Entity-Type

1a95660

Refactor Actron Air sensor tests to validate peripheral sensor keys a…

2b8c986

…nd improve assertions

kclif9 mentioned this pull request Dec 20, 2025

Actron air add sensor entity home-assistant/home-assistant.io#42662

Open

8 tasks

kclif9 marked this pull request as ready for review December 20, 2025 06:23

home-assistant bot requested review from JagadishDhanamjayam and zweckj December 20, 2025 06:23

kclif9 added 2 commits December 20, 2025 07:01

Update quality_scale.yaml to mark entity categories, device classes, …

e460c6e

…and disabled status as done

Update quality_scale.yaml to mark action-exceptions and reconfigurati…

7415691

…on-flow as exempt, and set entity-translations and exception-translations to done

joostlek requested changes Dec 20, 2025

View reviewed changes

home-assistant bot marked this pull request as draft December 20, 2025 08:52

		from .coordinator import ActronAirSystemCoordinator


		class ActronAirAcSensor(CoordinatorEntity[ActronAirSystemCoordinator]):

Uh oh!

Actron air add sensor entity type #158154

Are you sure you want to change the base?

Actron air add sensor entity type #158154

Conversation

kclif9 commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant bot commented Dec 7, 2025

Uh oh!

Uh oh!

kclif9 commented Dec 16, 2025

Uh oh!

kclif9 commented Dec 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kclif9 commented Dec 7, 2025 •

edited

Loading