Skip to content

fix: k8s version parsing to match original #31091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

fix: k8s version parsing to match original #31091

merged 1 commit into from
Aug 4, 2025

Conversation

8tomat8
Copy link
Contributor

@8tomat8 8tomat8 commented Jul 25, 2025 •
edited
Loading

What this PR does / why we need it:
Backport of #31078
Addresses the #31063
Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2025
TerryHowe
TerryHowe approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robertsirc
Copy link
Member

Thank you for your PR. As we are trying to maintain stability of Helm v3 for us to spend as much time on Helm v4 before code freeze. Is this request needed for Helm v3 or can we wait until v4?

@TerryHowe
Copy link
Contributor

Thank you for your PR. As we are trying to maintain stability of Helm v3 for us to spend as much time on Helm v4 before code freeze. Is this request needed for Helm v3 or can we wait until v4?

Some context:

#31078 (comment)

@robertsirc
Copy link
Member

Got it, let me take a look.

@ash2k ash2k mentioned this pull request Aug 1, 2025
Open
3 tasks
mattfarina
mattfarina approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agaudreault agaudreault mentioned this pull request Aug 1, 2025
Closed
@agaudreault
Copy link

Hi all, what is the expected ETA for a Helm v3 release with this fix? I am trying to coordinate the release of Argo CD with this fix included.

@TerryHowe TerryHowe mentioned this pull request Aug 2, 2025
Closed
@mattfarina mattfarina added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Aug 4, 2025
robertsirc
robertsirc approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsirc robertsirc merged commit ad28cfd into helm:dev-v3 Aug 4, 2025
5 checks passed
@agaudreault
Copy link

Hi all, what is the expected ETA for a Helm v3 release with this fix? I am trying to coordinate the release of Argo CD with this fix included.

@robertsirc Any info on the question above? 😄

@agaudreault agaudreault mentioned this pull request Aug 7, 2025
Merged
@scottrigby scottrigby added the bug Categorizes issue or PR as related to a bug. label Sep 5, 2025
@scottrigby scottrigby added this to the 3.19.0 milestone Sep 5, 2025
@TerryHowe TerryHowe mentioned this pull request Sep 6, 2025
Open
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

@robertsirc robertsirc robertsirc approved these changes

+1 more reviewer

@TerryHowe TerryHowe TerryHowe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Categorizes issue or PR as related to a bug. Has One Approval This PR has one approval. It still needs a second approval to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

3.19.0

Development

Successfully merging this pull request may close these issues.

6 participants

@8tomat8 @robertsirc @TerryHowe @agaudreault @mattfarina @scottrigby