Skip to content

Use own scheme rather than mutating a global shared one #11250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use own scheme rather than mutating a global shared one #11250

wants to merge 2 commits into from
+32 −61

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Aug 19, 2022

What this PR does / why we need it:

Fixes data race caused by code in Client. Fixes #11169.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2022
@ash2k ash2k force-pushed the use-local-scheme branch from 893f59f to c5a6701 Compare August 19, 2022 11:19
@ash2k
Copy link
Contributor Author

ash2k commented Nov 14, 2022

Hello?

@joejulian joejulian added this to the 3.10.3 milestone Nov 22, 2022
@hickeyma hickeyma modified the milestones: 3.10.3, 3.11.0 Dec 14, 2022
@ash2k
Copy link
Contributor Author

ash2k commented Jan 10, 2023

Conflict resolved, ready for merge.

@mattfarina mattfarina modified the milestones: 3.11.0, 3.12.0 Jan 18, 2023
@ash2k ash2k force-pushed the use-local-scheme branch 2 times, most recently from 8a58fe1 to e319614 Compare April 14, 2023 09:25
@joejulian joejulian modified the milestones: 3.12.0, 3.13.0 May 5, 2023
@ash2k
Copy link
Contributor Author

ash2k commented Jul 19, 2023

@joejulian Hi! I wonder if there is a reason this is not getting merged but getting bumped each time? It shouldn't cause any breakage, it fixes a data race. It's almost 1 year since I opened this PR.

@joejulian
Copy link
Contributor

I only recently became a maintainer and I've been working my way up through what I can. I only have an hour a day after work but I'm doing what I can.

@ash2k
Copy link
Contributor Author

ash2k commented Jul 19, 2023

Thank you! No pressure, just wanted to see if there is some other reason apart from lack of time.

@mattfarina mattfarina modified the milestones: 3.13.0, 3.14.0 Sep 25, 2023
@mattfarina mattfarina modified the milestones: 3.14.0, 3.15.0 Mar 13, 2024
@mattfarina mattfarina modified the milestones: 3.15.0, 3.16.0 Jun 12, 2024
@scottrigby scottrigby modified the milestones: 3.16.0, 3.17.0 Sep 11, 2024
@ash2k
Copy link
Contributor Author

ash2k commented Nov 15, 2024

Rebased to resolve a conflict. I still hope to see this merged.

@gjenkins8 gjenkins8 self-assigned this Dec 20, 2024
@scottrigby scottrigby modified the milestones: 3.17.0, 3.18.0 Jan 15, 2025
@ash2k ash2k mentioned this pull request Jan 23, 2025
Open
@ash2k ash2k force-pushed the use-local-scheme branch from 38cade1 to 9481cf1 Compare March 31, 2025 09:18
@ash2k
Copy link
Contributor Author

ash2k commented Mar 31, 2025

Conflict resolved, ready for merge.

@mattfarina mattfarina modified the milestones: 3.18.0, 3.19 May 19, 2025
@ash2k ash2k force-pushed the use-local-scheme branch from 9481cf1 to 4ce3ee7 Compare July 11, 2025 11:35
@ash2k
Copy link
Contributor Author

ash2k commented Jul 12, 2025

Conflict resolved, ready for merge. Almost 3 years now since I opened this PR.

@ash2k ash2k force-pushed the use-local-scheme branch 3 times, most recently from 33a15c2 to 19e4b73 Compare August 1, 2025 10:38
@ash2k
Copy link
Contributor Author

ash2k commented Aug 1, 2025 •
edited
Loading

@mattfarina Could you review/merge this PR please? It's been open for a while and I see the problematic code is being propagated further into the v3 packages.

p.s. Looks like #31078 is missing from v3 too. Ah, backport is here #31091.

@ash2k ash2k force-pushed the use-local-scheme branch from 19e4b73 to 45958a0 Compare August 19, 2025 05:58
@ash2k
Copy link
Contributor Author

ash2k commented Aug 19, 2025 •
edited
Loading

@gjenkins8 Hi! Since you are assigned, could you give this one a review/merged please?

p.s. wow, today is exactly 3 years since I opened it.

@scottrigby scottrigby added the bug Categorizes issue or PR as related to a bug. label Sep 11, 2025
@scottrigby
Copy link
Member

Please rebase to main first; backport to dev-v3 if Helm 3 also needs the fix.

@scottrigby scottrigby added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@scottrigby scottrigby modified the milestones: 3.19.0, 4.0.1 Sep 11, 2025
@ash2k
Copy link
Contributor Author

ash2k commented Sep 12, 2025

@scottrigby Rebased, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gjenkins8 gjenkins8

Labels

bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

Possible data race in kube.New because of AddToScheme

6 participants

@ash2k @joejulian @scottrigby @mattfarina @gjenkins8 @hickeyma