Skip to content

Android example: minor updates in prep for Quick start page creation #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Android example: minor updates in prep for Quick start page creation #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/android/src/main/kotlin/io/grpc/examples/helloworld/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ class MainActivity : AppCompatActivity() {
try {
val request = HelloRequest.newBuilder().setName(nameText.text.toString()).build()
val response = greeter.sayHello(request)
responseText.text = resources.getString(R.string.server_response, response.message)
responseText.text = response.message
} catch (e: Exception) {
responseText.text = resources.getString(R.string.server_error, e.message)
responseText.text = e.message
e.printStackTrace()
}
}
Expand Down
14 changes: 11 additions & 3 deletions examples/android/src/main/res/layout/activity_main.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,19 @@
<Button android:id="@+id/button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/say_hello"
android:text="@string/send_request"
android:enabled="false"/>

<TextView android:id="@+id/response_label"
android:layout_height="wrap_content"
android:layout_width="match_parent"
android:layout_margin="5dp"
android:textSize="18sp"
android:text="@string/server_response"/>

<TextView android:id="@+id/response"
android:layout_width="wrap_content"
android:layout_height="wrap_content"/>
android:layout_height="wrap_content"
android:layout_width="match_parent"
android:layout_marginHorizontal="5dp"/>

</LinearLayout>
7 changes: 3 additions & 4 deletions examples/android/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="name_hint">name</string>
<string name="say_hello">say hello</string>
<string name="name_hint">Name</string>
<string name="send_request">Send gRPC Request</string>
<string name="app_label">gRPC Kotlin Android</string>
<string name="server_response">Server says: %s</string>
<string name="server_error">Server error: %s</string>
<string name="server_response">Server response</string>
</resources>