Skip to content

Android example: minor updates in prep for Quick start page creation #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Android example: minor updates in prep for Quick start page creation #194

merged 1 commit into from
Oct 21, 2020

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 21, 2020

Screenshot:

Screen Shot 2020-10-21 at 12 08 54

Changes:

  • Rename button
  • Change server response layout. I find that this more clearly separates the server response text (which can be multiline in the case where we "say hello again") from the label "server response".
  • Other UI tweaks

These updates are in preparation for the new Kotlin Android Quick start, grpc/grpc.io#468.

@chalin
Android example: minor updates
abbe302 
Rename button and change server response layout.

These updates are in preparation for the new Kotlin Android Quick start.
@jamesward jamesward merged commit fbdcc91 into master Oct 21, 2020
@chalin chalin deleted the chalin-android-example-20201021 branch October 21, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamesward jamesward jamesward approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chalin @jamesward