This repository was archived by the owner on Jan 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Remove Goja from Execution Context Eval and from related parts #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
This was referenced Jan 24, 2024
ankur22
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a pretty big step forward into moving away from working with goja within the core business logic 👏
I've left comments for you to review, but I need to review it some more.
ankur22
suggested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. The code is easier to read without all that goja
back-and-forth type transformation.
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
We needed to everything in this PR in one Go for the code to compile.
Co-authored-by: Ankur Agarwal <[email protected]>
Co-authored-by: Ankur Agarwal <[email protected]>
Co-authored-by: Ankur Agarwal <[email protected]>
This commit is intentionally failing
00b7f9f
to
b34470e
Compare
These should be fixed.
b34470e
to
3ed072b
Compare
ankur22
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
added a commit
that referenced
this pull request
Jan 29, 2024
inancgumus
added a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
All of these changes are forced by the compiler and tests while working on
ExecutionContext.Eval
.ExecutionContext
. After this refactoring, everything started to fall apart, and we needed to refactor many parts of the code together. I couldn't split the second commit into smaller commits because it would break the build.common
types.convert
helper to convertany
values to type-safe values. There is another one in the test browser as a helper for the tests.Note
These additional PRs are created that will merge into this one.
Why?
Checklist
Related PR(s)/Issue(s)
Updates: #1182, #1170