This repository was archived by the owner on Jan 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Remove Goja from Execution Context Eval and from related parts #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
inancgumus
commented
Jan 24, 2024
This was referenced Jan 24, 2024
ankur22
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a pretty big step forward into moving away from working with goja within the core business logic 👏
I've left comments for you to review, but I need to review it some more.
ankur22
suggested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. The code is easier to read without all that goja
back-and-forth type transformation.
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
added a commit
that referenced
this pull request
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
inancgumus
commented
Jan 25, 2024
We needed to everything in this PR in one Go for the code to compile.
Co-authored-by: Ankur Agarwal <[email protected]>
What?
All of these changes are forced by the compiler and tests while working on
ExecutionContext.Eval
.ExecutionContext
. After this refactoring, everything started to fall apart, and we needed to refactor many parts of the code together. I couldn't split the second commit into smaller commits because it would break the build.common
types.convert
helper to convertany
values to type-safe values. There is another one in the test browser as a helper for the tests.Note
These additional PRs are created that will merge into this one.
Why?
Checklist
Related PR(s)/Issue(s)
Updates: #1182, #1170