Skip to content

Adding no-vu-connection-reuse option #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2018
Merged

Adding no-vu-connection-reuse option #676

merged 3 commits into from
Jun 20, 2018

Conversation

luizbafilho
Copy link
Contributor

This PR adds a new option --no-vu-connection-reuse that closes the idle connections between each iteration of a VU, and changes meaning of --no-connection-reuse to disabling keep-alive connections

@luizbafilho luizbafilho changed the title Adding no vu connection reuse Adding no-vu-connection-reuse option Jun 18, 2018
@luizbafilho luizbafilho changed the title Adding no-vu-connection-reuse option Adding no-vu-connection-reuse option Jun 18, 2018
@codecov-io
Copy link

codecov-io commented Jun 18, 2018 •
edited
Loading

Codecov Report

Merging #676 into master will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage    64.6%   64.63%   +0.02%     
==========================================
  Files         101      101              
  Lines        8166     8171       +5     
==========================================
+ Hits         5276     5281       +5     
  Misses       2549     2549              
  Partials      341      341
Impacted Files Coverage Δ
cmd/options.go 62.74% <100%> (+0.74%) ⬆️
lib/options.go 93.75% <100%> (+0.09%) ⬆️
js/runner.go 80.4% <50%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f207b...c4489c7. Read the comment docs.

na--
na-- approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

release notes/upcoming.md Outdated

## UX
* New option to reset cloud token (#672)
* The option `--no-connection-reuse` now means that keep-alive connections will be disabled. (#676)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this fit better as a Breaking Change or a Bugfix? Or even if it's in the UX section, a bit more information would probably help, something like:

The --no-connection-reuse option has been re-purposed and now disables keep-alive connections globally. The newly added --no-vu-connection-reuse option does what was previously done by --no-connection-reuse - it closes any open connections between iterations of a VU, but allows for reusing them inside of a single iteration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a breaking change session, it's going to be a better fit.

@luizbafilho luizbafilho merged commit 8f384ff into master Jun 20, 2018
@luizbafilho luizbafilho deleted the feature/disable-keep-alive-vu branch June 20, 2018 12:55
@na-- na-- mentioned this pull request Jun 25, 2018
Closed