Adding no-vu-connection-reuse option #676
Conversation
no-vu-connection-reuse option
no-vu-connection-reuse option
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 64.6% 64.63% +0.02%
==========================================
Files 101 101
Lines 8166 8171 +5
==========================================
+ Hits 5276 5281 +5
Misses 2549 2549
Partials 341 341
Continue to review full report at Codecov.
|
release notes/upcoming.md
Outdated
|
|
||
| ## UX | ||
| * New option to reset cloud token (#672) | ||
| * The option `--no-connection-reuse` now means that keep-alive connections will be disabled. (#676) |
There was a problem hiding this comment.
Wouldn't this fit better as a Breaking Change or a Bugfix? Or even if it's in the UX section, a bit more information would probably help, something like:
The
--no-connection-reuseoption has been re-purposed and now disables keep-alive connections globally. The newly added--no-vu-connection-reuseoption does what was previously done by--no-connection-reuse- it closes any open connections between iterations of a VU, but allows for reusing them inside of a single iteration.
There was a problem hiding this comment.
I think a breaking change session, it's going to be a better fit.
This PR adds a new option
--no-vu-connection-reusethat closes the idle connections between each iteration of a VU, and changes meaning of--no-connection-reuseto disabling keep-alive connections