Fix TestURLSkipRequest for Chrome 140+
#5165
Conversation
| // Under that assumption, it's important to notice that the Blob URL that we use | ||
| // for this test case isn't valid, and we cannot use a valid one because we lack | ||
| // general support for Blob and URL WebAPIs. | ||
| // However, until Chrome 139.x, there was a subtle bug causing no valid NavigationEvent to be emitted. |
There was a problem hiding this comment.
Do you have a chromium bug report that we can reference? It might be helpful if someone has to dig into this code again.
There was a problem hiding this comment.
It might be helpful if someone has to dig into this code again.
Yes, I have no doubts and fully agree with you.
Do you have a chromium bug report that we can reference?
But unfortunately no. I spent a decent amount of time trying to find it but I haven't been able to. And, at this point, I want to fix this to get our CI 🟢 again and focused on what I should have been focusing back to when I started to look at this 😓
If you have time and willingness, feel free to give it a try, maybe it's easier for you than it has been for me so far. But anyway, I'd prefer to get this merged in the meantime.
Note: This supersedes #5151
What?
It changes the expected behavior for the
TestURLSkipRequesttest.Why?
Because it started to fail (it changed) since Chrome 140. See more details in the code comments.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)