Skip to content

Add a temporary skip on TestURLSkipRequest #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add a temporary skip on TestURLSkipRequest #5151

wants to merge 3 commits into from

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Sep 9, 2025 •
edited
Loading

What?

We're adding a temporary skip on TestURLSkipRequest.

Why?

Only until we work out why this test is failing against the latest version of chromium.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@ankur22 ankur22 force-pushed the test/CI-url-skip-request-test branch 4 times, most recently from 466ff07 to 92e13e9 Compare September 9, 2025 11:12
@ankur22 ankur22 changed the title Add another assertion Add a temporary skip on TestURLSkipRequest Sep 9, 2025
@ankur22 ankur22 force-pushed the test/CI-url-skip-request-test branch from 92e13e9 to 9de857d Compare September 9, 2025 11:14
@ankur22
Add a skip on TestURLSkipRequest
be83e60 
Temporary skip while we work out why this test is failing with the
latest version of chromium.
@ankur22 ankur22 force-pushed the test/CI-url-skip-request-test branch from 9de857d to be83e60 Compare September 9, 2025 11:19
@ankur22 ankur22 marked this pull request as ready for review September 9, 2025 11:27
@ankur22 ankur22 requested a review from a team as a code owner September 9, 2025 11:27
@ankur22 ankur22 requested review from mstoykov and codebien and removed request for a team September 9, 2025 11:27
codebien
codebien reviewed Sep 10, 2025
View reviewed changes
@ankur22 ankur22 added this to the v1.3.0 milestone Sep 10, 2025
@joanlopez joanlopez mentioned this pull request Sep 10, 2025
Merged
8 tasks
@joanlopez
Copy link
Contributor

Closing, as fixed in #5165

@joanlopez joanlopez closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ankur22 @joanlopez @mstoykov @codebien