Skip to content

Upgrade embeded Kotlin to 2.3.0 #35339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbartok merged 44 commits into from
Dec 19, 2025
Merged

Upgrade embeded Kotlin to 2.3.0 #35339

jbartok merged 44 commits into from
Dec 19, 2025

Conversation

@jbartok
Copy link
Member

@jbartok jbartok commented Oct 16, 2025 •
edited by eskatos
Loading

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jbartok jbartok self-assigned this Oct 16, 2025
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch from 8d34c3f to 15cb54b Compare October 20, 2025 06:28
@jbartok jbartok changed the title Attempt to upgrade embeded Lotlin to 2.3.0-Beta1 Attempt to upgrade embeded Kotlin to 2.3.0-Beta1 Oct 20, 2025
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch 6 times, most recently from e57178a to 0565554 Compare October 25, 2025 09:03
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch 2 times, most recently from c97c9b7 to 2adb847 Compare November 3, 2025 11:03
@jbartok

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@jbartok

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch 3 times, most recently from 0b58fc9 to 18995a6 Compare November 4, 2025 09:21
@jbartok

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@jbartok

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle

This comment has been minimized.

Sign in to view
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch from 18995a6 to 75fec99 Compare November 5, 2025 08:12
@jbartok jbartok changed the title Attempt to upgrade embeded Kotlin to 2.3.0-Beta1 Attempt to upgrade embeded Kotlin to 2.3.0-BetaX Nov 5, 2025
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch 2 times, most recently from 2b29279 to 4e2f097 Compare November 6, 2025 09:36
jbartok added 19 commits December 19, 2025 08:44
@jbartok
Remove deprecated KotlinCoreEnvironment usage from test code
418a14c
@jbartok
Bump embedded Kotlin version to 2.3.0-RC2
c4df1ce
@jbartok
Make cross version test using the kotlin-dsl plugin skip the curren…
b293484 
…t version
@jbartok
Re-enable full support for Java 25
fa73ddd
@jbartok
Bump kotlin-dsl plugin version for Kotlin 2.3.0
afc3af3
@jbartok
Bump kotlin-dsl plugin version bringing Kotlin 2.3.0
69eca12
@jbartok
Re-enable cross-version tests that will now work
045eceb 
with the new version of the `kotlin-dsl` plugin
that has just been published
@jbartok
Remove TODO
39486e1
@jbartok
Bump embedded Kotlin versin to 2.3.0-RC3
2446f47
@jbartok
Release new version of kotlin-dsl plugin and use it
6bae012
@jbartok
Remove a TODO, will be covered separately
97e1a1c
@jbartok
Remove test cases for unsupported language versions
c1836ea
@jbartok
Ignore false positive stack trace detection in test output
6a48db5
@jbartok
Increase expected ALL distribution size
aa750d7
@jbartok
Bump embedded version to final 2.3.0
90c5005
@jbartok
Fix merge mismatch
ce27982
@jbartok
Release new version of kotlin-dsl plugin and use it
735fb88
@jbartok
Address post-merge issues
666df82
@jbartok
Address review concerns
07495c7
@jbartok jbartok mentioned this pull request Dec 19, 2025
Closed
@jbartok jbartok force-pushed the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch from 3eb445f to 07495c7 Compare December 19, 2025 07:25
@jbartok
Copy link
Member Author

jbartok commented Dec 19, 2025

@bot-gradle test this APT AST

@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle
Copy link
Collaborator

bot-gradle commented Dec 19, 2025

The following builds have passed:

@bot-gradle
Copy link
Collaborator

bot-gradle commented Dec 19, 2025

The following builds have passed:

@jbartok jbartok added this pull request to the merge queue Dec 19, 2025
@bot-gradle
Copy link
Collaborator

bot-gradle commented Dec 19, 2025

The following builds have passed:

Merged via the queue into master with commit d185c97 Dec 19, 2025
39 checks passed
@jbartok jbartok deleted the jb/tide/upgrade-embeded-kotlin-to-2.3.0-Beta1 branch December 19, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eskatos eskatos eskatos approved these changes

@h0tk3y h0tk3y Awaiting requested review from h0tk3y h0tk3y is a code owner automatically assigned from gradle/bt-tide

@ghale ghale Awaiting requested review from ghale ghale is a code owner automatically assigned from gradle/bt-jvm

@abstratt abstratt Awaiting requested review from abstratt abstratt is a code owner automatically assigned from gradle/bt-cortex

@asodja asodja Awaiting requested review from asodja asodja is a code owner automatically assigned from gradle/bt-cortex

+1 more reviewer

@usta usta usta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jbartok jbartok

Labels

a:chore Minor issue without significant impact in:kotlin-dsl

Projects

None yet

Milestone

9.4.0 RC1

Development

Successfully merging this pull request may close these issues.

Kotlin DSL fails with a compilation error in 9.2.0 if unicode symbols are present in gradle user home

6 participants

@jbartok @bot-gradle @eskatos @usta @h0tk3y