Upgrade embeded Kotlin to 2.3.0
#35339
Open
+210
−654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d34c3f to
15cb54b
Compare
2.3.0-Beta12.3.0-Beta1
e57178a to
0565554
Compare
c97c9b7 to
2adb847
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0b58fc9 to
18995a6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
18995a6 to
75fec99
Compare
2.3.0-Beta12.3.0-BetaX
2b29279 to
4e2f097
Compare
with the new version of the `kotlin-dsl` plugin that has just been published
74a1bfa to
3eb445f
Compare
Member
Author
|
@bot-gradle test APT AST |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have passed: |
Collaborator
|
The following builds have failed: |
eskatos
reviewed
Dec 18, 2025
| private static final JavaVersion MAX_SUPPORTED_JAVA_VERSION = | ||
| JavaVersion.forClassVersion( | ||
| JvmTarget.values().max { it.majorVersion }.majorVersion | ||
| JvmTarget.values().max { it.majorVersion }.majorVersion |
| pattern.replaceAll("current", "${INSTALLATION_GRADLE_VERSION.baseVersion.version}") | ||
| } | ||
| } | ||
| ) |
Member
There was a problem hiding this comment.
❓ IIUC these changes are not necessary anymore, are they? If yes, we should find another way because this feels just wrong.
| .withStackTraceChecksDisabled() | ||
| // Following lines from the deprecation warning look very much like stack traces, and they confuse our stack trace detection mechanisms... | ||
| // apiVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_1) | ||
| // languageVersion.set(org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_2_1) |
Member
There was a problem hiding this comment.
❓ I thought you took a stab at updating the regex detection stacktrace, didn't you?
Member
There was a problem hiding this comment.
This can be addressed in a follow up and doesn't block merging this PR
eskatos
approved these changes
Dec 18, 2025
Member
eskatos
left a comment
There was a problem hiding this comment.
LGTM 👍
Please address my comments from the previous review before merging, they are only about test and fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K1Deprecationopt-ins before Kotlin 2.3.0 #34952Context
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.Reviewing cheatsheet
Before merging the PR, comments starting with