Skip to content

Conversation

bot-gradle
Copy link
Collaborator

Merge master into release for next version

asodja and others added 30 commits January 22, 2025 09:06
The lock in the queue is highly contentious and may block project
configuration for a prolonged period of time. In gradle/gradle build,
the time spent locked goes up to 500ms per project, because their
configuration is effectively serialized.

This commit doesn't address the root cause, but highlights the
time-consuming operation in the build traces.
We've introduced another level of nesting.
We use an exception annotated with @contextual so that the error appears in the console.

This brings up a bigger question whether this annotation is worth having or not, or if we should
just print all exceptions to the console. I can see there being many exceptions that are being hidden
because of this annotation and the logic behind it
nagging whenever the flag is set, even if the value matches the default.
The flag is planned for removal in 9.0

The computation of the loadAfterStore parameter is made lazy, so that the DeprecationLogger has enough time to configure the problem reporting. Otherwise, the deprecation nagging is ignored silently.
The order of the computation is also changed, so that the nagging is unconditional, rather than being dependent on the short-circuiting of boolean expressions.
@bot-gradle bot-gradle requested a review from a team as a code owner February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle added the @dev-productivity Issue owned by developer-productivity label Feb 3, 2025
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle requested review from a team as code owners February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle requested review from a team and alllex as code owners February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from bamboo as a code owner February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team as a code owner February 3, 2025 10:07
@bot-gradle bot-gradle requested a review from a team February 3, 2025 10:07
@bot-gradle bot-gradle requested review from a team as code owners February 3, 2025 10:07
@bot-gradle
Copy link
Collaborator Author

Sorry, we can't process your request because of the following error:

Pull request Required status check "check_wrapper" is in progress.

@cobexer cobexer enabled auto-merge February 3, 2025 10:19
@cobexer cobexer disabled auto-merge February 3, 2025 10:21
@cobexer cobexer merged commit 845533f into release Feb 3, 2025
181 of 188 checks passed
@cobexer cobexer deleted the bot-pull-request-release-2025-02-03-10-07-31 branch February 3, 2025 10:22
@github-actions github-actions bot added pending:milestone Indicates that the completed issue requires a milestone to-triage labels Feb 3, 2025
@cobexer cobexer self-assigned this Feb 3, 2025
@cobexer cobexer added this to the 8.13 RC1 milestone Feb 3, 2025
@cobexer cobexer removed to-triage pending:milestone Indicates that the completed issue requires a milestone labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@dev-productivity Issue owned by developer-productivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.