Refactor Problems API #27184
Merged
Refactor Problems API #27184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 29, 2023
39aa506 to
e82df22
Compare
e82df22 to
354221f
Compare
354221f to
37826c3
Compare
aff719f to
23d7979
Compare
reinsch82
approved these changes
Dec 6, 2023
| } | ||
| @Nullable | ||
|
|
||
| @Override |
There was a problem hiding this comment.
❔ is this implicitely nullable because the constructor parameter is?
There was a problem hiding this comment.
Probably. It doesn't matter really as I'm working hard to refactor that part of the API separately.
23d7979 to
71384d2
Compare
- Remove stepwise builder - Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation() - Allow Problems API to define namespace - Separate private and public Problems API interface - Make transformers internal - Add ProblemBuilder.documentedAt(String) - Make problem instances not reference the Problems service - Make public API expose minimal set of features - Replace ProblemBuilder with Action<ProblemSpec> - ProblemBuilder extends ProblemSpec - Require exception in ProbemReporter.throwing(Action) - Move and cleanup ProblemLocation and its subclasses - Clean up task path location and rename identityPath to buildTreePath - Represent buildTreePath with String
71384d2 to
9e83bc6
Compare
|
WARN: This is a feature pull request but no changes to release note found. |
bot-gradle
added a commit
that referenced
this pull request
Dec 7, 2023
This PR contains the following changes:
- Remove stepwise builder
- Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation()
- Allow Problems API to define namespace
- Separate private and public Problems API interface
- Make transformers internal
- Add ProblemBuilder.documentedAt(String)
- Make problem instances not reference the Problems service
- Make public API expose minimal set of features
- Replace ProblemBuilder with Action<ProblemSpec>
- ProblemBuilder extends ProblemSpec
- Require exception in ProbemReporter.throwing(Action)
- Move and cleanup ProblemLocation and its subclasses
- Clean up task path location and rename identityPath to buildTreePath
- Represent buildTreePath with String
## Reviewing cheatsheet
### Before merging the PR, comments starting with
❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things
Co-authored-by: Donát Csikós <[email protected]>
The SSL certificate for the groovy-lang.org domain has just expired
|
@bot-gradle merge |
|
WARN: This is a feature pull request but no changes to release note found. |
|
Your PR is queued. See the queue page for details. |
|
Pre-tested commit build failed. Click here to see all build failures. |
bot-gradle
added a commit
that referenced
this pull request
Dec 7, 2023
This PR contains the following changes:
- Remove stepwise builder
- Remove ProblemBuilder.undocumented() and ProblemBuilder.noLocation()
- Allow Problems API to define namespace
- Separate private and public Problems API interface
- Make transformers internal
- Add ProblemBuilder.documentedAt(String)
- Make problem instances not reference the Problems service
- Make public API expose minimal set of features
- Replace ProblemBuilder with Action<ProblemSpec>
- ProblemBuilder extends ProblemSpec
- Require exception in ProbemReporter.throwing(Action)
- Move and cleanup ProblemLocation and its subclasses
- Clean up task path location and rename identityPath to buildTreePath
- Represent buildTreePath with String
## Reviewing cheatsheet
### Before merging the PR, comments starting with
❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things
Co-authored-by: Donát Csikós <[email protected]>
|
Your PR is queued. See the queue page for details. |
|
Error while scheduling pre-tested commit, please contact the administrator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Reviewing cheatsheet
Before merging the PR, comments starting with